Bug 10380 – [AA] Wrong code using associative array as key type in associative array

`TypeInfo_AssociativeArray` don't override `equals` and `compare` so one get mess if an associative array is used as a key type in an associative array. E.g. `keyti.compare` in `_aaEqual` calls `TypeInfo`'s `compare` which always return `0`.

Override `equals` in `TypeInfo_AssociativeArray`: https://github.com/D-Programming-Language/druntime/pull/523 Currently there is no comparison functions for AA-s, see Issue 10381.

Commit pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/1c6603e9c0f6081d12fa1cd898bc77db7769914a Override `equals` in `TypeInfo_AssociativeArray`. Fixes part of Issue 10380. Issue URL: http://d.puremagic.com/issues/show_bug.cgi?id=10380

Do you have any failing unittest for this bug? I can't seem to reproduce the problem in git HEAD.

(In reply to comment #3) > Do you have any failing unittest for this bug? I can't seem to reproduce the > problem in git HEAD. It's hard to create unittests as the problem will appear iff we will have to unequal AA-s with equal hashes.

I have a fix for this, but I need to somehow make a unittest to verify that it actually fixes the problem. Maybe we can somehow craft a unittest using typeid(aa).compare?

I figured out a way to test for broken .compare: make an AA key type that overrides both opEquals and opCmp, and deliberately have wrong implementation for opCmp.

Hi Denis, Can you check this bug again? Recently Kenji & I made some fixes in this area, and this may be fixed now. Could you verify?

(In reply to comment #8) > Hi Denis, > > Can you check this bug again? Recently Kenji & I made some fixes in this area, > and this may be fixed now. Could you verify? Currently `equals` is overriden in `TypeInfo_AssociativeArray` as druntime pull 523 is merged. But it doesn't changes this issue situation as `equals` isn't used. The issue will be fixed if e.g. this pull will be merged: https://github.com/D-Programming-Language/druntime/pull/522

*** Issue 6254 has been marked as a duplicate of this issue. ***

As pull 522 was rejected opened a new one for exactly this issue: https://github.com/D-Programming-Language/druntime/pull/736

Commits pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/33ea0c56407b4a37c382e3fbfb11206c66900dae Hack fix Issue 10380 - [AA] Wrong code using associative array as key type in associative array Issue URL: https://d.puremagic.com/issues/show_bug.cgi?id=10380 https://github.com/D-Programming-Language/druntime/commit/feb4560cb25ca6575c3491324a468a783c3567ba Merge pull request #736 from denis-sh/hack-fix-Issue-10380 Hack fix Issue 10380 - [AA] Wrong code using associative array as key type in associative array

Hack-fixed.

Commit pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/1b40f861923bb39a8fca9cb42f0268608860ad8c Revert "Hack fix Issue 10380 - [AA] Wrong code using associative array as key type in associative array" This reverts commit 33ea0c56407b4a37c382e3fbfb11206c66900dae.

Hack-fix is reverted as the issue is correctly fixed by druntime pull 522 [1] which is finally reopened and merged. [1] https://github.com/D-Programming-Language/druntime/pull/522