← Back to index | Original Bugzilla link

Bug 10931 – etc.c.zlib should properly annotate const parameters

Status: RESOLVED
Resolution: FIXED
Severity: normal
Priority: P2
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2013-08-30T12:54:00Z
Last change time: 2014-05-06T11:24:34Z
Keywords: pull
Assigned to: andrej.mitrovich
Creator: temtaime

Comments

Comment #0 by temtaime — 2013-08-30T12:54:11Z

All the source data should be declared as const, for example: int compress(ubyte* dest, size_t* destLen, ubyte* source, size_t sourceLen); Should be: int compress(ubyte* dest, size_t* destLen, const(ubyte)* source, size_t sourceLen);

Comment #1 by andrej.mitrovich — 2014-04-24T19:50:59Z

https://github.com/D-Programming-Language/phobos/pull/2123

Comment #2 by github-bugzilla — 2014-05-06T11:24:34Z

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/2493b9c7ebe4e18b5010d430ec43ac16f0dce02e Fix Issue 10931 - etc.c.zlib is missing proper const annotations for parameters and uses C-style pointer declarations. https://github.com/D-Programming-Language/phobos/commit/57aa14dd224a00fdffa5c5b1f31934aef1a88c04 Merge pull request #2123 from AndrejMitrovic/Fix10931 Issue 10931 - etc.c.zlib is missing proper const annotations for parameters and uses C-style pointers