Bug 11049 – array bounds error uses module file name rather than file name modified by #line directive

This test case cannot pass assertions. void main() { int[] arr = [1,2,3]; #line 100 "foo" try { auto n = arr[3]; } catch (Error e) { assert(e.file == "foo"); // fails assert(e.line == 100); } #line 200 "bar" try { auto a = arr[3..9]; } catch (Error e) { assert(e.file == "bar"); // fails assert(e.line == 200); } }

Just ran into this today. Removing the pull description because even though the PR was pulled, this is not fixed, not sure what happened.

I'll note this is important to fix, as vibe.d is a showcase project of D, and diet templates use #line to help diagnose issues with diet templates.

This is apparently caused by the code in e2ir.d: elem *buildArrayBoundsError(IRState *irs, const ref Loc loc) { if (irs.params.checkAction == CHECKACTION.C) { return callCAssert(irs, loc, null, null, "array overflow"); } if (irs.params.checkAction == CHECKACTION.halt) { return genHalt(loc); } auto eassert = el_var(getRtlsym(RTLSYM_DARRAYP)); auto efile = toEfilenamePtr(cast(Module)irs.blx._module); *** auto eline = el_long(TYint, loc.linnum); return el_bin(OPcall, TYvoid, eassert, el_param(eline, efile)); } Note that it gets the filename from _module rather than loc. I believe it is this way to stop the redundant generation of filename strings into the object file. The previous function filelineFunction() gets it fro the loc.

@WalterBright created dlang/dmd pull request #11741 "fix Issue 11049 - array bounds error uses module file name rather tha…" fixing this issue: - fix Issue 11049 - array bounds error uses module file name rather than file name modified by #line directive https://github.com/dlang/dmd/pull/11741

dlang/dmd pull request #11741 "fix Issue 11049 - array bounds error uses module file name rather tha…" was merged into master: - 26d0f3557d125b2ec43ead7b61e08d855fc12751 by Walter Bright: fix Issue 11049 - array bounds error uses module file name rather than file name modified by #line directive https://github.com/dlang/dmd/pull/11741