Bug 11254 – std.string.strip is not nothrow

Status
RESOLVED
Resolution
INVALID
Severity
enhancement
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2013-10-14T02:52:00Z
Last change time
2013-10-14T19:41:32Z
Assigned to
nobody
Creator
bearophile_hugs

Comments

Comment #0 by bearophile_hugs — 2013-10-14T02:52:27Z
import std.string: strip; void main() nothrow { " hello ".strip; } dmd 2.064beta gives: test.d(3): Error: 'std.string.strip!(immutable(char)).strip' is not nothrow test.d(2): Error: function 'D main' is nothrow yet may throw I don't know if this can be done. Often string functions need to decode UTF, and this could raise exceptions. In most cases, or for ASCII strings, a strip can't throw exceptions. If this can't be done then please close down this issue.
Comment #1 by monarchdodra — 2013-10-14T05:55:11Z
(In reply to comment #0) > import std.string: strip; > void main() nothrow { > " hello ".strip; > } > > > > dmd 2.064beta gives: > > test.d(3): Error: 'std.string.strip!(immutable(char)).strip' is not nothrow > test.d(2): Error: function 'D main' is nothrow yet may throw > > > I don't know if this can be done. Often string functions need to decode UTF, > and this could raise exceptions. In most cases, or for ASCII strings, a strip > can't throw exceptions. > > If this can't be done then please close down this issue. strip is a unicode aware function, that can remove unicode whites, so it *must* decode. So even if "most of the time", it won't throw, in the generic case, it can.
Comment #2 by bearophile_hugs — 2013-10-14T09:46:51Z
(In reply to comment #1) > strip is a unicode aware function, that can remove unicode whites, so it *must* > decode. So even if "most of the time", it won't throw, in the generic case, it > can. Some possible alternative solutions: - A strip-like function that works on ubyte[] (the return type of std.string.representation if you give it a string); - A compile-time switch for std.string.strip that compiles out the unicode-aware parts. - A std.ascii.astrip nothrow function designed to work only on ASCII strings/char[].
Comment #3 by monarchdodra — 2013-10-14T11:50:50Z
(In reply to comment #2) > (In reply to comment #1) > > > strip is a unicode aware function, that can remove unicode whites, so it *must* > > decode. So even if "most of the time", it won't throw, in the generic case, it > > can. > > Some possible alternative solutions: > - A strip-like function that works on ubyte[] (the return type of > std.string.representation if you give it a string); > - A compile-time switch for std.string.strip that compiles out the > unicode-aware parts. > - A std.ascii.astrip nothrow function designed to work only on ASCII > strings/char[]. You should try the new generic std.algorithm.strip: //---- import std.string, std.ascii, std.algorithm; void main(string[] args) nothrow pure { string s = " hello! "; s = cast(string)s.representation.strip!isWhite(); } //----
Comment #4 by issues.dlang — 2013-10-14T19:41:32Z
I think that we should probably move towards overloading string functions with ubyte[] so that they can have ASCII-specific versions, and more of those would be able to be nothrow.