Bug 11512 – Can't build Phobos docs with win32 makefile
Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2013-11-13T10:56:00Z
Last change time
2013-12-10T03:54:31Z
Keywords
pull
Assigned to
nobody
Creator
andrej.mitrovich
Comments
Comment #0 by andrej.mitrovich — 2013-11-13T10:56:54Z
C:\dmd-git\dmd2\src\phobos>make -f win32.mak HTML
Error: don't know how to make './std.ddoc'
Worked fine a while ago, but not anymore. The 2.064.2 release works fine too.
Comment #1 by k.hara.pg — 2013-12-05T00:29:35Z
I'm not sure this is a regression in git-head.
https://github.com/D-Programming-Language/phobos/commit/40854fd7e20af1749a2d7a048c263caf2209d538
std.ddoc file has been removed from 3 years ago, but release package (eg. 2.064.2.zip) contains std.ddoc in src/phobos directory.
If you want to create Phobos document in your local, you need to specify the path to the dlang.org repo.
C:\dmd2\src\phobos> make -f win32.mak html DOCSRC=../dlang.org
Comment #2 by andrej.mitrovich — 2013-12-05T03:55:29Z
(In reply to comment #1)
> I'm not sure this is a regression in git-head.
Well it definitely stopped working even though I didn't change any of my paths.
> std.ddoc file has been removed from 3 years ago, but release package (eg.
> 2.064.2.zip) contains std.ddoc in src/phobos directory.
>
> If you want to create Phobos document in your local, you need to specify the
> path to the dlang.org repo.
>
> C:\dmd2\src\phobos> make -f win32.mak html DOCSRC=../dlang.org
That works, thanks. But I think this should be documented somewhere, maybe in the readme file.
Comment #3 by braddr — 2013-12-05T11:56:50Z
Doesn't that strongly suggest that the default value for DOCSRC is wrong and should be changed in the make files?
Comment #4 by k.hara.pg — 2013-12-09T19:40:24Z
This is not a regression, so I change the importance to "major".
(In reply to comment #3)
> Doesn't that strongly suggest that the default value for DOCSRC is wrong and
> should be changed in the make files?
https://github.com/D-Programming-Language/phobos/pull/1761
Comment #5 by braddr — 2013-12-09T21:07:40Z
In what way is it not a regression. Before a change was made, something worked. After the change, it no longer worked. That's the very definition of a regression. Changing back.
Anyway, I never build the docs, so Andrej if you can confirm that the pull works for you we can get this merged and move on.
Comment #6 by k.hara.pg — 2013-12-09T21:28:36Z
(In reply to comment #5)
> In what way is it not a regression. Before a change was made, something
> worked. After the change, it no longer worked. That's the very definition of
> a regression. Changing back.
>
> Anyway, I never build the docs, so Andrej if you can confirm that the pull
> works for you we can get this merged and move on.
Because the few changes for the phobos win32.mak file in least 6 months didn't touch DOCSRC variable definition. So I couldn't think that Andrej's DOCSRC issue is a regression of git-head.
Comment #7 by andrej.mitrovich — 2013-12-10T02:27:48Z
The new pull request fixes this, thanks Kenji.
Comment #8 by github-bugzilla — 2013-12-10T03:09:52Z