Bug 11764 – [REG2.065a]std.getopt broken

This code doesn't work (git HEAD): import std.getopt; import std.stdio; void main() { auto args = ["main", "-test"]; bool opt; args.getopt(config.passThrough, "opt", &opt); writeln(args); assert(args == ["main", "-test"]); } ---- $ dmd -run main ["main", "-t", "est"] core.exception.AssertError@main(10): Assertion failure

Introduced by: https://github.com/D-Programming-Language/phobos/pull/1779

I guess getopt should check whether the option exists before it tries to separate "-abc" to -a=bc?

This is intentional because arguably the use was incorrectly accepted. The commonly used convention is to either use short (single-letter) options with single dash, or long options (multi-letter) with double dashes. The use '-test' is currently interpreted as "pass argument est to the single-letter option -t". That said, a regression is what it is so perhaps we need to continue supporting the old mistake. I'll look into it. Please advise.

(In reply to comment #3) > This is intentional because arguably the use was incorrectly accepted. The > commonly used convention is to either use short (single-letter) options with > single dash, or long options (multi-letter) with double dashes. > > The use '-test' is currently interpreted as "pass argument est to the > single-letter option -t". I think the OPs point however is that the passThrough option should let *you* handle any unsupported syntax like single-dash long options *after* getopt is done, hence why it should not split up "-test" (if there's no -t option then it should arguably not try to split up -test).

Oh I see. Nice!

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/4900690b77ebcd0ae3248119f706e0efac7dcfdc Fix issue 11764 https://github.com/D-Programming-Language/phobos/commit/ac83fa77067e50142723d480614ec72d6c40a459 Merge pull request #1783 from andralex/getopt Fix issue 11764