Bug 11831 – std.zip no longer allows setting madeVersion field in zip file

Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P2
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2013-12-27T11:54:00Z
Last change time
2014-01-02T09:37:34Z
Keywords
pull
Assigned to
nobody
Creator
bugzilla

Comments

Comment #0 by bugzilla — 2013-12-27T11:54:21Z
std.zip needs to allow access to all fields in zip file's data structures. The data structures written to disk should not have inaccessible private fields. This regression blocks compilation of the chmodzip tool, which needs to be able to set madeVersion because Linux unzippers look for specific version numbers there. https://github.com/D-Programming-Language/tools/pull/61
Comment #1 by bugzilla — 2013-12-27T15:59:12Z
Comment #2 by code — 2013-12-27T17:56:15Z
https://github.com/D-Programming-Language/phobos/pull/1817 (In reply to comment #0) > std.zip needs to allow access to all fields in zip file's data structures. The > data structures written to disk should not have inaccessible private fields. The fact that std.zip is barely unusable and that most of it's members are undocumented should tell you a different story. madeVersion was explicitly documented as read only field btw. http://dlang.org/phobos/std_zip.html#.ArchiveMember.madeVersion > This regression blocks compilation of the chmodzip tool, which needs to be able > to set madeVersion because Linux unzippers look for specific version numbers > there. The set version number (20) works fine, it's 0x0300 in the upper byte which needs to be set for Unix format file attribute. https://github.com/D-Programming-Language/phobos/blob/e37d30fb10b94f8a3ac9013d92c7be661e52eb6b/std/zip.d#L136
Comment #3 by github-bugzilla — 2013-12-27T19:38:58Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/eac5ec14d2ff8ce7c666edaea0607bd01733364a fix Issue 11831 - std.zip no longer allows setting madeVersion field - add deprecated ref accessor https://github.com/D-Programming-Language/phobos/commit/8c570a0b1f210601360eb7a594863a85fddca971 Merge pull request #1817 from MartinNowak/fix11831 fix Issue 11831 - std.zip no longer allows setting madeVersion field
Comment #4 by github-bugzilla — 2014-01-02T09:37:34Z
Commit pushed to 2.065 at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/a087fcb2c39ae13e8a0c3eb2494adae15683c6ee fix Issue 11831 - std.zip no longer allows setting madeVersion field - add deprecated ref accessor