Bug 11854 – Git-head does not build with Visual Studio

Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P2
Component
dmd
Product
D
Version
D2
Platform
All
OS
All
Creation time
2013-12-31T08:18:00Z
Last change time
2013-12-31T14:02:31Z
Keywords
pull
Assigned to
andrej.mitrovich
Creator
andrej.mitrovich

Comments

Comment #0 by andrej.mitrovich — 2013-12-31T08:18:55Z
> 1>mars.c(97): fatal error C1189: #error : "fix this" Specifically: ----- #if TARGET_WINDOS obj_ext = "obj"; #elif TARGET_LINUX || TARGET_OSX || TARGET_FREEBSD || TARGET_OPENBSD || TARGET_SOLARIS obj_ext = "o"; #else #error "fix this" #endif ----- IIRC I saw a recent pull pushing the TARGET_WINDOS define somewhere into a makefile, so the visual studio project file should likely add this define too.
Comment #1 by andrej.mitrovich — 2013-12-31T08:23:57Z
(In reply to comment #0) > so the visual studio project file should likely add this define too. Specifically it's added via (taken from http://msdn.microsoft.com/en-us/library/hhzbb5c8.aspx): Open the project Property Pages dialog box. For more information, see How to: Open Project Property Pages. In the left pane, select Configuration Properties, C/C++, Preprocessor. In the right pane, in the right-hand column of the Preprocessor Definitions property, open the drop-down menu and choose Edit. In the Preprocessor Definitions dialog box, add (one per line), modify, or delete one or more definitions. Choose OK to save your changes. Note that each definition goes on its own line rather than being separated by a space (silly VS make-me-think design..).
Comment #2 by andrej.mitrovich — 2013-12-31T08:31:30Z
Comment #3 by github-bugzilla — 2013-12-31T12:46:41Z
Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/e5d5d6e4c8a28fdc4d90e29e17bb4c5efbc491cc Fix Issue 11854 - VS Project file missing a define. https://github.com/D-Programming-Language/dmd/commit/34fc8dd50854a1ac1c1862ddadb2df2a33bf241e Merge pull request #3053 from AndrejMitrovic/Fix11854 Issue 11854 - VS Project file missing a define.