Bug 12178 – Odd whitespace look on dlang website

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
dlang.org
Product
D
Version
D2
Platform
All
OS
All
Creation time
2014-02-15T03:49:00Z
Last change time
2014-02-23T22:09:29Z
Keywords
pull
Assigned to
nobody
Creator
andrej.mitrovich

Attachments

IDFilenameSummaryContent-TypeSize
1324Clipboard02.pngimageimage/png3491
1325Clipboard02.pngtest2image/png5977

Comments

Comment #0 by andrej.mitrovich — 2014-02-15T03:49:32Z
Created attachment 1324 image Note the space before the first "opt", and before and after the second "opt", it's a tab instead of a space. It makes the docs look long and ugly.
Comment #1 by k.hara.pg — 2014-02-16T01:14:50Z
(In reply to comment #0) > Created an attachment (id=1324) [details] > image > > Note the space before the first "opt", and before and after the second "opt", > it's a tab instead of a space. It makes the docs look long and ugly. That's word wrapping of your browser view.
Comment #2 by andrej.mitrovich — 2014-02-16T02:40:16Z
(In reply to comment #1) > That's word wrapping of your browser view. It's still an issue, even if not a ddoc issue. I'm retagging it as a website issue. The documentation should look nice regardless of the browser you're using.
Comment #3 by k.hara.pg — 2014-02-16T03:07:56Z
(In reply to comment #2) > (In reply to comment #1) > > That's word wrapping of your browser view. > > It's still an issue, even if not a ddoc issue. I'm retagging it as a website > issue. The documentation should look nice regardless of the browser you're > using. I'm not sure it is an issue. It might always occur with long declaration signatures. For example: /// long function signature void aLongLong_tooLongFunctionIdentifier(LongLongParameterType1 longLongParameterName1, LongLongParameterType2 longLongParameterName2, LongLongParameterType3 longLongParameterName3, ...);
Comment #4 by andrej.mitrovich — 2014-02-16T04:42:25Z
Created attachment 1325 test2
Comment #5 by andrej.mitrovich — 2014-02-16T04:42:59Z
(In reply to comment #4) > Created an attachment (id=1325) [details] > test2 This is what I think is a reasonable look. IOW I don't see why the excessive whitespace was added between parameters, it looks really odd in picture 1.
Comment #6 by k.hara.pg — 2014-02-16T05:03:46Z
(In reply to comment #5) > (In reply to comment #4) > > Created an attachment (id=1325) [details] [details] > > test2 > > This is what I think is a reasonable look. IOW I don't see why the excessive > whitespace was added between parameters, it looks really odd in picture 1. So it's style issue. It will be fixed by: dlang.org/css/style.css .d_decl { font-weight: bold; background-color: #E4E9EF; /* border-top: solid black 1px; */ border-bottom: solid 2px #336600; padding: 2px 0px 2px 2px; text-align: left; // <---- added }
Comment #7 by andrej.mitrovich — 2014-02-16T05:16:49Z
(In reply to comment #6) > So it's style issue. It will be fixed by: > > dlang.org/css/style.css > > .d_decl { > font-weight: bold; > background-color: #E4E9EF; > /* border-top: solid black 1px; */ > border-bottom: solid 2px #336600; > padding: 2px 0px 2px 2px; > text-align: left; // <---- added > } Thanks. As long as others agree they want this we could make the change. I don't want to impose my style over anyone elses. CC'ing Andrei.
Comment #8 by andrei — 2014-02-16T07:31:35Z
Yes, that text should not be justified. I wanted to fix that since forever but didn't get to it. Could you please submit a pull request?
Comment #9 by k.hara.pg — 2014-02-16T15:37:07Z
Comment #10 by github-bugzilla — 2014-02-16T16:46:29Z
Commits pushed to master at https://github.com/D-Programming-Language/dlang.org https://github.com/D-Programming-Language/dlang.org/commit/7bb40822806a28f6d46c4906d4200decf45ccfe7 fix Issue 12178 - Odd whitespace look on dlang website https://github.com/D-Programming-Language/dlang.org/commit/b5d8cfca09696cbb0477621322ced83566c1094f Merge pull request #501 from 9rnsr/fix12178 Issue 12178 - Odd whitespace look on dlang website
Comment #11 by github-bugzilla — 2014-02-23T01:11:10Z
Commit pushed to 2.065 at https://github.com/D-Programming-Language/dlang.org https://github.com/D-Programming-Language/dlang.org/commit/40ca19804e8899934aa3dd0a01e169916784ceb2 Merge pull request #501 from 9rnsr/fix12178 Issue 12178 - Odd whitespace look on dlang website
Comment #12 by github-bugzilla — 2014-02-23T22:09:29Z