Bug 12293 – forward is missing from std.algorithm's cheat-sheet

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
dlang.org
Product
D
Version
D2
Platform
All
OS
All
Creation time
2014-03-03T08:55:00Z
Last change time
2014-04-28T11:16:11Z
Keywords
pull
Assigned to
andrej.mitrovich
Creator
dev

Comments

Comment #0 by dev — 2014-03-03T08:55:55Z
std.algorithm.forward is missing from the index at the top of http://dlang.org/phobos/std_algorithm.html
Comment #1 by k.hara.pg — 2014-04-26T16:00:16Z
(In reply to Gary Willoughby from comment #0) > std.algorithm.forward is missing from the index at the top of > http://dlang.org/phobos/std_algorithm.html If the issue is the un-listing of 'forward' function, why it should go std.functional module? You should explain the reason.
Comment #2 by andrej.mitrovich — 2014-04-26T17:49:37Z
(In reply to Kenji Hara from comment #1) > (In reply to Gary Willoughby from comment #0) > > std.algorithm.forward is missing from the index at the top of > > http://dlang.org/phobos/std_algorithm.html > > If the issue is the un-listing of 'forward' function, why it should go > std.functional module? You should explain the reason. No, I've changed the title. See the history here: https://issues.dlang.org/show_activity.cgi?id=12293
Comment #3 by k.hara.pg — 2014-04-26T18:07:55Z
(In reply to Andrej Mitrovic from comment #2) > No, I've changed the title. See the history here: > https://issues.dlang.org/show_activity.cgi?id=12293 If the reason comes from just your feeling, I cannot agree with the title. std.algorithm.forward is in the same category of std.algorithm.move and swap. Why they are in std.algorithm module? Because in C++03, std::swap was in <algorithm> header. So in D, swap, move, and forward are in std.algorithm. I know that std::swap, move, and forward are in <utility> header in C++11. But, std.functional module is for "functional programming" utilities. From the perspective, swap, move, and forward are not directly related to functional programming IMO. So, I think that moving it to the module is unreasonable change.
Comment #4 by andrej.mitrovich — 2014-04-26T21:07:09Z
(In reply to Kenji Hara from comment #3) > (In reply to Andrej Mitrovic from comment #2) > > No, I've changed the title. See the history here: > > https://issues.dlang.org/show_activity.cgi?id=12293 > > If the reason comes from just your feeling, I cannot agree with the title. I wasn't the one to suggest it, it was monarchdodra. Originally I made the pull that added 'forward' to the cheat-sheet of the std.algorithm page. I can recreate this pull again if desired. > std.algorithm.forward is in the same category of std.algorithm.move and swap. > Why they are in std.algorithm module? Because in C++03, std::swap was in > <algorithm> header. So in D, swap, move, and forward are in std.algorithm. That sounds reasonable to me then. Unless monarchdodra objects I'll recreate the cheat-sheet pull.
Comment #5 by monarchdodra — 2014-04-26T22:54:54Z
(In reply to Andrej Mitrovic from comment #4) > (In reply to Kenji Hara from comment #3) > > (In reply to Andrej Mitrovic from comment #2) > > > No, I've changed the title. See the history here: > > > https://issues.dlang.org/show_activity.cgi?id=12293 > > > > If the reason comes from just your feeling, I cannot agree with the title. > > I wasn't the one to suggest it, it was monarchdodra. What !? > AndrejMitrovic commented 4 days ago > https://issues.dlang.org/show_bug.cgi?id=12293 > > Honestly I think forward doesn't belong in std.algorithm. > It should likely belong to std.functional or a similar place. > Hence why I had to add a "utility" category. I'd rather we > just move the template out of std.algorithm though. You suggested it. I just told you to go through with it. > Originally I made the > pull that added 'forward' to the cheat-sheet of the std.algorithm page. I > can recreate this pull again if desired. Sure. > > std.algorithm.forward is in the same category of std.algorithm.move and swap. > > Why they are in std.algorithm module? Because in C++03, std::swap was in > > <algorithm> header. So in D, swap, move, and forward are in std.algorithm. > > That sounds reasonable to me then. Unless monarchdodra objects I'll recreate > the cheat-sheet pull. Sounds reasonable to me too. Revert back to how it was?
Comment #6 by andrej.mitrovich — 2014-04-26T22:56:46Z
(In reply to monarchdodra from comment #5) > What !? > You suggested it. I just told you to go through with it. *Facepalm*. It appears I did. Sorry for this. :>
Comment #7 by andrej.mitrovich — 2014-04-26T23:00:05Z
Comment #8 by github-bugzilla — 2014-04-28T11:16:11Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/8c24b1e875e67263dc19d32e9f20346f9785ce23 Fix Issue 12293 - Add forward to std.algorithm's cheat-sheet. https://github.com/D-Programming-Language/phobos/commit/f2c630a0eabb1fe7013d112897c22812e026e8a5 Merge pull request #2099 from AndrejMitrovic/Fix12293 Issue 12293 - forward is missing from std.algorithm's cheat-sheet