Bug 1238 – Private identifiers in imported modules create conflicts with public ones

Repro: // ---- start import std.stdio; import std.stream; import std.ctype; void main() { writefln("%d", isdigit('1')); } // ---- end The problem seems to be the couple of "helper functions" at the end of stream.d. Easiest workaround would probably simply declaring them static as well as private (and the same probably applies to other module-scope private variables/functions in Phobos). Anyway, since the spec states that "Private module members are equivalent to static declarations in C programs" (in "Attributes"), declaring anything "private" at module scope should probably force static linkage.

A self-contained testcase: ---------- module ppc_1a; import ppc_1b; import ppc_1c; int qwert = yuiop; ---------- module ppc_1b; private int yuiop; ---------- module ppc_1c; public int yuiop; ---------- ppc_1a.d(5): Error: ppc_1b.yuiop at ppc_1b.d(3) conflicts with ppc_1c.yuiop at ppc_1c.d(3) ppc_1a.d: module ppc_1a ppc_1b.yuiop is private ----------

*** Bug 1754 has been marked as a duplicate of this bug. ***

Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/1218502560ca19d7cf95bf277525b17c3b7186eb fixed Issue 1238

Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/e6c8554df338a13202d4140ea7a6b1b37853f5c1 Revert "fixed Issue 1238" This reverts commit 1218502560ca19d7cf95bf277525b17c3b7186eb.

This is still a problem with D2... adding a private function shouldn't break the build of user modules. There's no ambiguity because obviously the private one is never wanted as it is inaccessible anyway.

*** Issue 10411 has been marked as a duplicate of this issue. ***

*** Issue 13096 has been marked as a duplicate of this issue. ***

*** Issue 14301 has been marked as a duplicate of this issue. ***

Faced this again, this is a serious bug that's 8 years old !! What are the difficulties involved in fixing this? For example, I see workarounds such as https://issues.dlang.org/show_bug.cgi?id=14301 which don't really address the root cause. Anything wrong with http://wiki.dlang.org/DIP22?

(In reply to Timothee Cour from comment #9) > Faced this again, this is a serious bug that's 8 years old !! > > What are the difficulties involved in fixing this? exactly zero difficulties. Kenji's PR3416 works like a charm, i'm using it since a long time ago, and has ZERO problems with it. except some missing imports in some projects, which i reported and authors happily fixed — and that couldn't be found without the patch, accumulating bugs and "we can't merge the patch as it will break user code" murmur. i'm almost sure now that modules are broken by intention, as having a solution for such a long time and happily ignoring it (and me writing about it) looks like a plan, not like an oversight. so calm down and get used to it, it will never be fixed.

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/a96d7c0b499ab2b4bd8e6b3ea87ee4a3858b9aab Add workaround for issue 1238 https://github.com/D-Programming-Language/phobos/commit/5faa1ccfc1ad69bf076225d51249c75caaaa2144 Merge pull request #3158 from tom-tan/workaround-for-14405 Add workaround for issue 1238

Commits pushed to stable at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/a96d7c0b499ab2b4bd8e6b3ea87ee4a3858b9aab Add workaround for issue 1238 https://github.com/D-Programming-Language/phobos/commit/5faa1ccfc1ad69bf076225d51249c75caaaa2144 Merge pull request #3158 from tom-tan/workaround-for-14405

Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/8839a6c8c24777b576e3594629804185cff21c0e fix issue 1238