← Back to index | Original Bugzilla link

Bug 12389 – Operating system C functions should be marked as 'nothrow'

Status: RESOLVED
Resolution: WORKSFORME
Severity: normal
Priority: P2
Component: druntime
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2014-03-17T03:54:00Z
Last change time: 2017-07-18T14:19:18Z
Keywords: preapproved
Assigned to: nobody
Creator: bugzilla

Comments

Comment #0 by bugzilla — 2014-03-17T03:54:19Z

Very few C function declarations in druntime are marked as nothrow, even though all the OS ones are. Marking them as nothrow enables important optimizations. I've marked one file here as an example: https://github.com/D-Programming-Language/druntime/pull/742 The rest of the imports need to be gone through and fixed as well.

Comment #1 by qznc — 2016-05-22T11:19:53Z

Resolved as of https://github.com/dlang/druntime/commit/3c9aee8fcb1d9 ?

Comment #2 by dlang-bugzilla — 2017-07-18T14:19:18Z

(In reply to qznc from comment #1) > Resolved as of https://github.com/dlang/druntime/commit/3c9aee8fcb1d9 ? Seems like it. Closing; please reopen or file a new bug if any specific modules are still missing the annotation.