← Back to index | Original Bugzilla link

Bug 12462 – std.bitmanip.BitArray should use new-style operator overloads

Status: RESOLVED
Resolution: WORKSFORME
Severity: normal
Priority: P2
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2014-03-25T05:49:15Z
Last change time: 2019-12-14T09:49:27Z
Keywords: pull
Assigned to: Andrej Mitrovic
Creator: Andrej Mitrovic
See also: https://issues.dlang.org/show_bug.cgi?id=18665

Comments

Comment #0 by andrej.mitrovich — 2014-03-25T05:49:15Z

It seems to use the old opCom/opAnd/etc, these might even be deprecated some day. The fact that they're there might encourage users to write the old-style operators in their own code.

Comment #1 by bearophile_hugs — 2014-03-25T06:09:27Z

(In reply to comment #0) > It seems to use the old opCom/opAnd/etc, these might even be deprecated some > day. The fact that they're there might encourage users to write the old-style > operators in their own code. DMD 2.066 should give warnings where you use old-style operator overloading.

Comment #2 by safety0ff.bugz — 2014-07-03T20:13:16Z

Once PR #2249 [1] gets pulled there will only be opCom / opCat / opCat_r / opCatAssign. The discussion [2] seemed to conclude that we should not change the operators for the sake of changing them. However, the changes in PR #2249 are not baseless. [1] https://github.com/D-Programming-Language/phobos/pull/2249 [2] http://forum.dlang.org/thread/[email protected]

Comment #3 by bearophile_hugs — 2014-07-03T20:22:09Z

(In reply to safety0ff.bugz from comment #2) > The discussion [2] seemed to conclude that we should not change the > operators for the sake of changing them. I don't agree. I think the old style operator overloading should be deprecated as soon as possible.

Comment #4 by bugzilla — 2019-12-14T09:49:27Z

Seems to be fixed...