Bug 12470 – std.array.replace does not work with inout(char)[]

----- import std.array; inout(char)[] sanitize(inout(char)[] input) { return input.replace("\0", " "); } ----- $ dmd test.d ----- C:\dmd-git\dmd2\windows\bin\..\..\src\phobos\std\array.d(1835): Error: template std.array.replaceInto cannot deduce function from argument types !()(Appender!(inout(char)[]), inout(char)[], string, string), candidates are: C:\dmd-git\dmd2\windows\bin\..\..\src\phobos\std\array.d(1844): std.array.replaceInto(E, Sink, R1, R2)(Sink sink, E[] subject, R1 from, R2 to) if (isOutputRange!(Sink, E) && isDynamicArray!(E[]) && isForwardRange!R1 && isForwardRange!R2 && (hasLength!R2 || isSomeString!R2)) test.d(7): Error: template instance std.array.replace!(inout(char), string, string) error instantiating ----- Note that this is an internal library error.

Still, that code cannot be compiled, right? inout is a wildcard that should be able to take place of const and immutable but std.array.replace cannot work with const(char)[] nor with immutable(char)[].

(In reply to comment #1) > Still, that code cannot be compiled, right? > > inout is a wildcard that should be able to take place of const and immutable > but std.array.replace cannot work with const(char)[] nor with > immutable(char)[]. I thought it was supposed to allocate a new array to store the result to?

(In reply to comment #2) > (In reply to comment #1) > > Still, that code cannot be compiled, right? > > > > inout is a wildcard that should be able to take place of const and immutable > > but std.array.replace cannot work with const(char)[] nor with > > immutable(char)[]. > > I thought it was supposed to allocate a new array to store the result to? Seems that way: http://dlang.org/phobos/std_array.html#replace Replace occurrences of from with to in subject. Returns a new array without changing the contents of subject, or the original array if no match is found. /---- import std.array, std.stdio; void main() { int[] c = [1, 2, 3]; c.replace([2], [4, 4]).writeln(); //[1, 4, 4, 3]; c.writeln(); //[1, 2, 3]; c.idup.replace([2], [4, 4]).writeln(); //[1, 4, 4, 3]; } //---- Ali must be thinking about "replaceInPlace" ?

Sorry for the noise. :( Yes, I thought it was in-place.

It seems the bottom-line problem is this: ----- import std.array; import std.range; inout(char)[] sanitize(inout(char)[] input) { auto app = appender!(inout(char)[])(); // fails because of inout(char) as the element type static assert(isOutputRange!(typeof(app), inout(char))); } ----- And it fails because of this strange nested declaration inside of the put method: @property ref E[] EArrayInit(); //@@@9186@@@: Can't use (E[]).init std\range.d(656): Error: inout on return means inout must be on a parameter as well for @property ref inout(char)[]() I guess this was some kind of funky workaround, but it causes issues for 12470. I'm not sure how to proceed yet.

Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/722ecd878cfde16a87d1f04e2ed3f5df08a9b78d fix issue 12470 - std.array.replace does not work with inout(char)[] https://github.com/dlang/phobos/commit/fc468500c90894919cec3783ce674f9b0f9b329e Merge pull request #5735 from BBasile/issue-12470 fix issue 12470 - std.array.replace does not work with inout(char)[]

Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/722ecd878cfde16a87d1f04e2ed3f5df08a9b78d fix issue 12470 - std.array.replace does not work with inout(char)[] https://github.com/dlang/phobos/commit/fc468500c90894919cec3783ce674f9b0f9b329e Merge pull request #5735 from BBasile/issue-12470