Bug 13237 – Wrong code with "-inline -O"

introduced by https://github.com/D-Programming-Language/dmd/pull/3819 size_t getLength(int[] arr) { return arr.length; } void main() { int[] arr = [0]; immutable size_t len = getLength(arr); arr.length--; assert(len == 1); // ok if (len) { auto l = len; } assert(len == 1); // len cannot be changed, but produces Assertion failure with "-O -inline" }

Sorry, I forgot to write that this code is reduced from an overload of std.algorithm.find. https://github.com/D-Programming-Language/phobos/blob/master/std/algorithm.d#L4586 The first problem I found was enforce(find("{", "{") == "{"); this fails when it's compiled with -O and -inline.

*** Issue 13251 has been marked as a duplicate of this issue. ***

sinkuu, I am particularly grateful you posted this bug report, and you even figured out which change caused it. I hate subtle optimizer bugs, and am really glad to get this one fixed before shipping. Thanks!

Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/02ca8d7c4532cd69ce8a0dfcddf7b394cb196891 fix Issue 13237 Wrong code with -inline -O https://github.com/D-Programming-Language/dmd/commit/0131c148f32f662bd64725b8af58472066fc5781 Merge pull request #3848 from WalterBright/fix13237 fix Issue 13237 Wrong code with -inline -O

Commit pushed to dmd-1.x at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/955a6d4b89911c6e4cac4594a55158237968208c fix Issue 13237 Wrong code with -inline -O Conflicts: test/runnable/test23.d

Commit pushed to 2.066 at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/8631eb8f9748d147f5353dc5585632ff3aa6dabc Merge pull request #3848 from WalterBright/fix13237 fix Issue 13237 Wrong code with -inline -O

Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/8631eb8f9748d147f5353dc5585632ff3aa6dabc Merge pull request #3848 from WalterBright/fix13237