← Back to index | Original Bugzilla link

Bug 13263 – phobos/posix.mak has incorrect dependencies

Status: RESOLVED
Resolution: FIXED
Severity: normal
Priority: P1
Component: phobos
Product: D
Version: D2
Platform: x86
OS: Mac OS X
Creation time: 2014-08-05T22:40:00Z
Last change time: 2014-08-13T19:52:55Z
Keywords: pull
Assigned to: nobody
Creator: andrei

Comments

Comment #0 by andrei — 2014-08-05T22:40:00Z

Simply running "make" twice in succession for Phobos compiles the library twice. That means the dependencies are wrong.

Comment #1 by code — 2014-08-06T09:30:30Z

It's a bit annoying, but not necessarily a problem. This happens because druntime_libs [1] is a PHONY target and phobos depends on it. The PHONY target was introduced because the druntime rule actually creates two output files. [1]: https://github.com/D-Programming-Language/phobos/blob/922d1931fe4e3a84b788e7e4f8f11de3dc05cfe1/posix.mak#L374

Comment #2 by andrei — 2014-08-06T14:41:42Z

Such small issues tend to compound into bigger ones. I think we need to fix this. We could make phobos dependent on the actual druntime library, or just not list it as a dependency. Thoughts?

Comment #3 by code — 2014-08-09T15:43:56Z

I just used $(DRUNTIME) as target, so make doesn't know about the additional $(DRUNTIMESO) output. I think this is good enough as the archive and the shared library shouldn't be out-of-sync. https://github.com/D-Programming-Language/phobos/pull/2409

Comment #4 by github-bugzilla — 2014-08-13T19:52:55Z

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/8f12e8062fc26a428a23f417eddebce73c854506 fix Issue 13263 - replace phony druntime_libs target with $(DRUNTIME) - add fake FORCE dependency to always invoke druntime's makefile https://github.com/D-Programming-Language/phobos/commit/2f9e056bb88a24cb3f01f77f79abc732ebd1e1c7 Merge pull request #2409 from MartinNowak/fix13263 fix Issue 13263