Bug 13358 – Comments in core.demangle refer to TypeIdent, TypeClass, etc. as LNames when they are parsed as QualifiedNames

Status
NEW
Severity
enhancement
Priority
P4
Component
druntime
Product
D
Version
D2
Platform
All
OS
All
Creation time
2014-08-22T16:43:17Z
Last change time
2024-12-07T13:34:11Z
Assigned to
No Owner
Creator
Orvid King
Moved to GitHub: dmd#17282 →

Comments

Comment #0 by blah38621 — 2014-08-22T16:43:17Z
As stated in the subject, core.demangle's internal comments refer to TypeIdent, TypeClass, TypeName, TypeEnum, and TypeTypedef as being LName values, but it parsed them as QualifiedName values. And, as long as someone is messing with the comments in core.demangle, it would probably be a good idea to split up the comment describing the structure of a TypeFunction to have only the part the method it's above actually uses, and to move the rest to the methods that actually parse that piece. This would make it consistent with the rest of the style used in core.demangle.
Comment #1 by robert.schadek — 2024-12-07T13:34:11Z
THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/dmd/issues/17282 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB