← Back to index | Original Bugzilla link

Bug 13419 – code cleanup in std.uni: removing "comma expressions"

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2014-09-03T12:27:00Z
Last change time
2014-09-12T20:23:23Z
Keywords
pull
Assigned to
nobody
Creator
ketmar

Attachments

IDFilenameSummaryContent-TypeSize
1412kill_commas_std_uni.patchremoving comma-expressions in std.unitext/plain3780

Comments

Comment #0 by ketmar — 2014-09-03T12:27:44Z
Created attachment 1412 removing comma-expressions in std.uni this removes all "return n, b" abominations in std.uni. no other phobos or druntime sources has that.
Comment #1 by hsteoh — 2014-09-04T23:13:18Z
The comma expressions are being used to induce the compiler to inline the functions. Technically, this really should be a compiler enhancement bug (should not need to use comma expression to trigger inlining). But anyway, somebody already submitted a PR for this: https://github.com/D-Programming-Language/phobos/pull/2485
Comment #2 by github-bugzilla — 2014-09-10T20:55:19Z
Commit pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/a965ffb5502f96b38f9698bfe00ce075b22c7d01 Merge pull request #2485 from schuetzm/ketmar-kill-the-commas Issue 13419 - Remove comma expression in std.uni