← Back to index | Original Bugzilla link

Bug 13429 – icmp (and friends) should be @nogc

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2014-09-06T08:21:09Z
Last change time
2019-06-10T07:40:07Z
Keywords
industry
Assigned to
No Owner
Creator
Manu

Comments

Comment #0 by turkeyman — 2014-09-06T08:21:09Z
icmp (and friends) should be @nogc. It is the most frequently occurring function blocking use of @nogc in my code. Surely a string comparison doesn't need to allocate?
Comment #1 by lt.infiltrator — 2015-12-03T15:01:07Z
I think that it does for unicode. I'm going to close off as INVALID because icmp need unicode.
Comment #2 by ag0aep6g — 2015-12-03T16:06:52Z
Reopening. std.uni.icmp is only not @nogc, because it may throw a GC allocated Exception. Exceptions that don't rely on the GC are being worked towards (e.g. by making them reference counted), in particular to enable more of Phobos to be @nogc.
Comment #3 by lt.infiltrator — 2015-12-06T14:26:12Z
I was wrong in closing this as INVALID; or at all. I don't even know what I was thinking. Sorry for the noise.
Comment #4 by github-bugzilla — 2016-12-08T21:09:27Z
Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/40787cee7f3ab4a3c747d47124e614d7b30cbbf1 Issue 13429: make sicmp and icmp @nogc nothrow https://github.com/dlang/phobos/commit/5c770fba084a5e7addfaf65ab6deb36584ee2fd7 Merge pull request #4933 from sprinkle131313/master Issue 13429: make sicmp and icmp @nogc nothrow.
Comment #5 by github-bugzilla — 2017-01-07T03:02:58Z
Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/40787cee7f3ab4a3c747d47124e614d7b30cbbf1 Issue 13429: make sicmp and icmp @nogc nothrow https://github.com/dlang/phobos/commit/5c770fba084a5e7addfaf65ab6deb36584ee2fd7 Merge pull request #4933 from sprinkle131313/master
Comment #6 by github-bugzilla — 2017-01-16T23:25:38Z
Commits pushed to newCTFE at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/40787cee7f3ab4a3c747d47124e614d7b30cbbf1 Issue 13429: make sicmp and icmp @nogc nothrow https://github.com/dlang/phobos/commit/5c770fba084a5e7addfaf65ab6deb36584ee2fd7 Merge pull request #4933 from sprinkle131313/master
Comment #7 by iamthewilsonator — 2019-06-10T07:40:07Z
This got fixed in https://github.com/dlang/phobos/pull/4933