← Back to index | Original Bugzilla link

Bug 13445 – std.process fails to create process with empty (non-null) working directory

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
x86_64
OS
Windows
Creation time
2014-09-09T14:12:00Z
Last change time
2014-09-09T15:26:18Z
Keywords
pull
Assigned to
nobody
Creator
dlang-bugzilla

Attachments

IDFilenameSummaryContent-TypeSize
1421z.patchfixtext/plain924

Comments

Comment #0 by dlang-bugzilla — 2014-09-09T14:12:11Z
https://issues.dlang.org/show_bug.cgi?id=11363#c2 Fails on both Windows and POSIX. Not sure if this is a bug, since if you specify an empty / non-null parameter to the OS API it will fail as well.
Comment #1 by dlang-bugzilla — 2014-09-09T14:16:20Z
https://github.com/D-Programming-Language/phobos/pull/2502
Comment #2 by ketmar — 2014-09-09T14:20:49Z
Created attachment 1421 fix heh. there is another bug with workDir: workDirFD CAN be zero, it's perfectly valid FD. ;-) fix attached.
Comment #3 by dlang-bugzilla — 2014-09-09T14:22:55Z
Care to turn that into a pull request, or can I add that as a commit for you?
Comment #4 by ketmar — 2014-09-09T14:42:48Z
just merge this with yours: i missed windows fix anyway.
Comment #5 by dlang-bugzilla — 2014-09-09T14:47:04Z
OK, I added your patch to my pull as a separate commit, and credited you as the commit author: https://github.com/CyberShadow/phobos/commit/462163a5b0b29d112558d4b2d612bdfc9b183208
Comment #6 by ketmar — 2014-09-09T14:52:57Z
thank you. i don't care about credits, though: it's ok to use my patches fully or partially without crediting me.
Comment #7 by github-bugzilla — 2014-09-09T15:26:17Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/53f5405a516755f12f762882abd38fac6b60ad95 fix Issue 13445 - std.process fails to create process with empty (non-null) working directory https://github.com/D-Programming-Language/phobos/commit/d479da3392e9d8b8194c5b6078bcadc4ea4e889d Merge pull request #2502 from CyberShadow/pull-20140909-140509 fix Issue 13445 - std.process fails to create process with empty (non-null) working directory