Bug 13826 – Move volatileLoad/Store to core.volatile when the volatile keyword is removed

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
druntime
Product
D
Version
D2
Platform
All
OS
All
Creation time
2014-12-07T00:47:44Z
Last change time
2019-08-29T18:40:24Z
Keywords
pull
Assigned to
No Owner
Creator
Mike Franklin

Comments

Comment #0 by slavo5150 — 2014-12-07T00:47:44Z
It was decided in the conversation for pull request https://github.com/D-Programming-Language/dmd/pull/4155 that when the volatile keyword becomes available, volatileLoad/Store intrinsics should be moved to core.volatile as core.bitop was an unpopular location. See https://github.com/D-Programming-Language/druntime/pull/892.
Comment #1 by slavo5150 — 2016-08-28T01:11:06Z
volatile keyword was removed in March 2016: https://github.com/dlang/dmd/pull/5556
Comment #2 by ibuclaw — 2018-10-25T20:57:39Z
Comment #3 by github-bugzilla — 2018-11-03T21:57:07Z
Commit pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/3a29b26449d9a214800e122e1da200626fa66be0 Merge pull request #8869 from ibuclaw/issue13826 Add compiler support for core.volatile.volatileLoad/Store
Comment #4 by dlang-bot — 2019-08-29T15:05:12Z
@ErnyTech created dlang/druntime pull request #2773 "Fix Issue 13826 - Move volatileLoad/Store to core.volatile when the volatile keyword is removed" fixing this issue: - Fix Issue 13826 - Move volatileLoad/Store to core.volatile when the volatile keyword is removed This PR move the intrinsic volatileLoad and volatileStore into core.volatile, as promised by the discussion in https://github.com/dlang/druntime/pull/892 and https://github.com/dlang/dmd/pull/4155. Currently an alias is maintained in core.bitop to avoid broken code, the alias is marked as deprecated to warn users of the displacement occurred in the core.volatile You should probably schedule a removal of the alias from core.bitop and publish it in https://dlang.org/deprecate.html Signed-off-by: Ernesto Castellotti <[email protected]> https://github.com/dlang/druntime/pull/2773
Comment #5 by dlang-bot — 2019-08-29T15:37:40Z
@ErnyTech created dlang/dmd pull request #10370 "Fix Issue 13826 - Move volatileLoad/Store to core.volatile when the volatile keyword is removed" fixing this issue: - Fix Issue 13826 - Move volatileLoad/Store to core.volatile when the volatile keyword is removed This PR move the intrinsic volatileLoad and volatileStore into core.volatile, as promised by the discussion in #892 and dlang/dmd#4155. This PR removes the support for the intrinsic of volatileLoad and volatileStore in the core.bitop module This PR depends on: https://github.com/dlang/druntime/pull/2773 Signed-off-by: Ernesto Castellotti <[email protected]> https://github.com/dlang/dmd/pull/10370
Comment #6 by dlang-bot — 2019-08-29T17:19:51Z
dlang/druntime pull request #2773 "Fix Issue 13826 - Move volatileLoad/Store to core.volatile when the volatile keyword is removed" was merged into master: - bc1ef748ca37533500f6d510bef854420ce6febf by Ernesto Castellotti: Fix Issue 13826 - Move volatileLoad/Store to core.volatile when the volatile keyword is removed This PR move the intrinsic volatileLoad and volatileStore into core.volatile, as promised by the discussion in #892 and dlang/dmd#4155. Currently an alias is maintained in core.bitop to avoid broken code, the alias is marked as deprecated to warn users of the displacement occurred in the core.volatile You should probably schedule a removal of the alias from core.bitop and publish it in https://dlang.org/deprecate.html Signed-off-by: Ernesto Castellotti <[email protected]> https://github.com/dlang/druntime/pull/2773
Comment #7 by dlang-bot — 2019-08-29T18:40:24Z
dlang/dmd pull request #10370 "Fix Issue 13826 - Move volatileLoad/Store to core.volatile when the volatile keyword is removed" was merged into master: - e0e2071e059d6e2849e1fc962d61f891c2d100f2 by Ernesto Castellotti: Fix Issue 13826 - Move volatileLoad/Store to core.volatile when the volatile keyword is removed This PR move the intrinsic volatileLoad and volatileStore into core.volatile, as promised by the discussion in #892 and #4155. This PR removes the support for the intrinsic of volatileLoad and volatileStore in the core.bitop module This PR depends on: dlang/druntime#2773 Signed-off-by: Ernesto Castellotti <[email protected]> https://github.com/dlang/dmd/pull/10370