Bug 13990 – std.algorithm.move incorrectly uses hasAliasing for class references

If we have an opaque class, we can't move the reference with std.algorithm.move: import std.algorithm.move class S; void main() { S s; S s2; std.algorithm.move(s, s2); // Error, size of S unknown. } However, all move has to do is assignment in this case. The issue is that we have a static if that checks hasAliasing on the class type to do a check for internal pointers, but that is only relevant for structs. It should be moved inside the check to see if it's a struct. Doing pull request now.

PR: https://github.com/D-Programming-Language/phobos/pull/2876 Note, I couldn't just put the code inside structs, because unit tests also want to make sure a pointer isn't self-pointing.

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/0afa52f5996c0e80e3e0067fa14bfc9b955bebca Fix issue 13990, Now you can move opaque classes. https://github.com/D-Programming-Language/phobos/commit/02be4bdd5593794eb40848e5c2e3304e52fa83e6 Merge pull request #2876 from schveiguy/issue13990 Fix issue 13990 -- std.algorithm.move incorrectly uses hasAliasing for class references

fixed: void move(T)(ref T source, ref T target) not fixed: T move(T)(ref T source)

Bleh, I can't be expected to find all the instances of a function I never use ;) I'll add another PR.

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/8ccd882556b13afa9b8f72c0c41e72709e701c41 Fix second move overload for issue 13990 https://github.com/D-Programming-Language/phobos/commit/8814b27d8d333f07dfd00dda2a6c4a7dc35cc348 Merge pull request #2894 from schveiguy/issue13990_b Fix issue 13990 part 2 -- std.algorithm.move incorrectly uses hasAliasing for class references

Commits pushed to 2.067 at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/0afa52f5996c0e80e3e0067fa14bfc9b955bebca Fix issue 13990, Now you can move opaque classes. https://github.com/D-Programming-Language/phobos/commit/02be4bdd5593794eb40848e5c2e3304e52fa83e6 Merge pull request #2876 from schveiguy/issue13990 https://github.com/D-Programming-Language/phobos/commit/8ccd882556b13afa9b8f72c0c41e72709e701c41 Fix second move overload for issue 13990 https://github.com/D-Programming-Language/phobos/commit/8814b27d8d333f07dfd00dda2a6c4a7dc35cc348 Merge pull request #2894 from schveiguy/issue13990_b