Bug 14104 – aa with pointer key type doesn't find existing value

Found in Higgs, apparently introduced by https://github.com/D-Programming-Language/dmd/pull/4159. The key type is const(ubyte)*. I tracked it down to differing TypeInfos. On insertion it's TypeInfo_Pointer [1] for opIn it's TypeInfo_P [2]. The latter computes a different hash. [1]: https://github.com/D-Programming-Language/druntime/blob/f0c1e13d8bd547eed517b1ae17f085966bb165c1/src/object_.d#L361 [2]: https://github.com/D-Programming-Language/druntime/blob/2024ca6d3e29362a2fc84ef51c0f73316259d645/src/rt/typeinfo/ti_ptr.d#L18

Here's small test case for 64-bit: void main() { int[const(ubyte)*] aa; const(ubyte)* p = cast(const(ubyte)*) 0x1_0000_0000; aa[p] = 1; assert(aa[p] == 1); assert(p in aa); }

Commits pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/cc8046dd390a974e57a8062e2fb98402726208e7 fix Issue 14104 - aa with pointer key type doesn't find existing value - the internal TypeInfo_P.getHash for pointers trucated the hash to 32-bit unlike the TypeInfo_Pointer.getHash - internal TypeInfos are used when no full type information is needed so they must behave identical https://github.com/D-Programming-Language/druntime/commit/86f8b7cd760ac1b21059f9953d58569808eeec09 Merge pull request #1150 from MartinNowak/fix14104 fix Issue 14104 - aa with pointer key type doesn't find existing value

Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/13d0da1e7ec9a02bf7757e6d1cf6470f59cf6ff5 Merge pull request #4389 from rainers/issue14104 fix issue 14104 - nuke getInternalTypeInfo

Commit pushed to https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/13d0da1e7ec9a02bf7757e6d1cf6470f59cf6ff5 Merge pull request #4389 from rainers/issue14104

Commits pushed to 2.067 at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/cc8046dd390a974e57a8062e2fb98402726208e7 fix Issue 14104 - aa with pointer key type doesn't find existing value https://github.com/D-Programming-Language/druntime/commit/86f8b7cd760ac1b21059f9953d58569808eeec09 Merge pull request #1150 from MartinNowak/fix14104

*** Issue 14182 has been marked as a duplicate of this issue. ***