Bug 14192 – Access Violation when assigning to shared AA

unittest { shared int[int] _map; _map[1] = 1; } --------------------------- Error --------------------------- object.Error@(0): Access Violation ---------------- 0x0052E494 in _aaGetImpl druntime 3f99ef5 dmd f47c8f60 phobos ed896ca21

stack trace object.Error@(0): Access Violation ---------------- 0x0040322F in _aaGetImpl at D:\D\digger\repo\druntime\src\rt\aaA.d(215) 0x00402381 in _aaGetY at D:\D\digger\repo\druntime\src\rt\aaA.d(189) 0x0040203D in void test.__unittestL1_1() at D:\D\test.d(3) 0x00402068 in void test.__modtest() at D:\D\test.d(4)

It's because of the precise scanning. DMD passes the type info to _aaGetY, which is actually a wrapper TypeInfo_Shared, but the function is prototyped as accepting TypeInfo_AssociativeArray. See my comment here: https://github.com/D-Programming-Language/druntime/pull/1037#issuecomment-74678635

Note, the unittest is incidental, it happens with just: void main() { shared int[int] aa; aa[1] = 1; }

(In reply to Steven Schveighoffer from comment #2) > It's because of the precise scanning. DMD passes the type info to _aaGetY, > which is actually a wrapper TypeInfo_Shared, but the function is prototyped > as accepting TypeInfo_AssociativeArray. > > See my comment here: > https://github.com/D-Programming-Language/druntime/pull/1037#issuecomment- > 74678635 The root is mostly same with issue 14038.

A shared AA doesn't make too much sense BTW, because you'll need some additional synchronization mechanism if you want to modify it. And if you use a http://dlang.org/phobos/core_sync_rwmutex.html#.ReadWriteMutex for example you only need tail-shared for the value type.

Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/5afc1177551fa8f6e43bb1fc499698eaab41655a fix Issue 14192 - Access Violation when assigning to shared AA - the runtime expects an unqualified TypeInfo for the AA and crashes if it is wrapped inside a TypeInfo_Shared https://github.com/D-Programming-Language/dmd/commit/4091ddc1af08f3a65512e41a19ffda06335471c2 Merge pull request #4420 from MartinNowak/fix14192 fix Issue 14192 - Access Violation when assigning to shared AA

Commit pushed to 2.067 at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/2077a7fc4a3842030ef2df7429d0e225242443a0 Merge pull request #4420 from MartinNowak/fix14192 fix Issue 14192 - Access Violation when assigning to shared AA

Commits pushed to https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/5afc1177551fa8f6e43bb1fc499698eaab41655a fix Issue 14192 - Access Violation when assigning to shared AA https://github.com/D-Programming-Language/dmd/commit/4091ddc1af08f3a65512e41a19ffda06335471c2 Merge pull request #4420 from MartinNowak/fix14192

Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/2077a7fc4a3842030ef2df7429d0e225242443a0 Merge pull request #4420 from MartinNowak/fix14192

Commits pushed to stable at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/5afc1177551fa8f6e43bb1fc499698eaab41655a fix Issue 14192 - Access Violation when assigning to shared AA https://github.com/D-Programming-Language/dmd/commit/4091ddc1af08f3a65512e41a19ffda06335471c2 Merge pull request #4420 from MartinNowak/fix14192

Commits pushed to dmd-cxx at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/5afc1177551fa8f6e43bb1fc499698eaab41655a fix Issue 14192 - Access Violation when assigning to shared AA https://github.com/dlang/dmd/commit/4091ddc1af08f3a65512e41a19ffda06335471c2 Merge pull request #4420 from MartinNowak/fix14192