Bug 14283 – [2.067-b4]: Spurious "this is not an lvalue" deprecation message for "auto ref" arguments

"auto ref" should deduce "this" argument to non-ref to avoid a deprecation message showing up for valid code. The original place where this was triggered was for std.typecons.scoped, where all arguments are declared as "auto ref". --- class C { void foo() { bar(this); } } void bar()(auto ref C) {} --- (3): Deprecation: this is not an lvalue

*** Issue 14284 has been marked as a duplicate of this issue. ***

It could be a bad idea to handle 'this' as lvalue (with deprecation) but infer and rvalue for auto ref. Also it required quite some hacking. I think a better choice is to keep it as lvalue but omit the deprecation message for auto ref parameters. In both cases I hardly expect any code breakage, as passing 'this' to an auto ref parameter hardly comprises the intent to change the this pointer.

Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/6db86fdba070751ebbccede55b134aef1f791d46 fix Issue 14283 - spurious 'this' is not an lvalue deprecation for auto ref - suppress deprecation message for auto ref parameters as passing 'this' to auto ref will remain correct when it becomes an rvalue and because it's very unlikely that the passing as ref argument was intentional https://github.com/D-Programming-Language/dmd/commit/3bc3f1cd69d43db971a75a1ad36a04e2ac914fe9 Merge pull request #4497 from MartinNowak/fix14283 fix Issue 14283 - spurious 'this' is not an lvalue deprecation for auto ref

Commit pushed to 2.067 at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/56e59d841a3854afb8509f5930bfa4016fa7443d Merge pull request #4497 from MartinNowak/fix14283 fix Issue 14283 - spurious 'this' is not an lvalue deprecation for auto ref

Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/56e59d841a3854afb8509f5930bfa4016fa7443d Merge pull request #4497 from MartinNowak/fix14283

Commits pushed to stable at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/6db86fdba070751ebbccede55b134aef1f791d46 fix Issue 14283 - spurious 'this' is not an lvalue deprecation for auto ref https://github.com/D-Programming-Language/dmd/commit/3bc3f1cd69d43db971a75a1ad36a04e2ac914fe9 Merge pull request #4497 from MartinNowak/fix14283