Bug 14329 – [2.067] offline doc - menu broken due to missing jquery-1.7.2.min.js

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P1
Component
dlang.org
Product
D
Version
D2
Platform
All
OS
Windows
Creation time
2015-03-24T22:57:00Z
Last change time
2015-06-18T16:54:34Z
Keywords
pull
Assigned to
nobody
Creator
b2.temp

Comments

Comment #0 by b2.temp — 2015-03-24T22:57:15Z
The documentation distributed with the 2067 release cant be browsed **offline** because the expandable menus are broken due to a missing js in html/d/js, (jquery-1.7.2.min.js). For example if you start from index.html. How to reproduce: clean the browser cache, unplug your ethernet cable and open index.html... The script should stand in the offline equivalent of http://dlang.org/js/.
Comment #1 by code — 2015-03-25T01:34:25Z
Don't the menus work without js? And seriously how useful are the offline HTML docs?
Comment #2 by dlang-bugzilla — 2015-03-25T01:35:47Z
The reason is that jquery-1.7.2.min.js is missing from the makefile rules, BTW
Comment #3 by b2.temp — 2015-03-25T18:56:56Z
"And seriously how useful are the offline HTML docs?" example: my employee work on a ultra-secure intra network without internet access and i don't want to upload the script on each terminal after each release. More seriously, just put it. There is another BR by a chinese guy who complains about that, because the internet source of jquery is blocked over there...
Comment #4 by dlang-bugzilla — 2015-03-25T18:59:13Z
Comment #5 by dlang-bugzilla — 2015-03-25T19:00:24Z
You should be able to use the CHM in the meanwhile.
Comment #6 by dlang-bugzilla — 2015-03-25T19:01:45Z
(In reply to bb.temp from comment #3) > More seriously, just put it. There is another BR by a chinese guy who > complains about that, because the internet source of jquery is blocked over > there... We fixed that a while ago by adding a local fallback. It's just that our local copy didn't end up in the DMD .zip file.
Comment #7 by github-bugzilla — 2015-03-29T14:41:42Z
Commits pushed to master at https://github.com/D-Programming-Language/dlang.org https://github.com/D-Programming-Language/dlang.org/commit/f074e250f9ac0079801b3e98eeaad2d33d1c0d98 fix Issue 14329 - [2.067] offline doc - menu broken due to missing jquery-1.7.2.min.js Add jquery to JS file list to posix.mak https://github.com/D-Programming-Language/dlang.org/commit/0a92173a062697436456bb84a936ce0d0a3097f8 Merge pull request #942 from CyberShadow/pull-20150325-145525 fix Issue 14329 - [2.067] offline doc - menu broken due to missing jquer...
Comment #8 by github-bugzilla — 2015-03-29T14:43:40Z
Commit pushed to stable at https://github.com/D-Programming-Language/dlang.org https://github.com/D-Programming-Language/dlang.org/commit/a01054ce8224c0464a4e0d540ec6190e80bdabe7 Merge pull request #942 from CyberShadow/pull-20150325-145525 fix Issue 14329 - [2.067] offline doc - menu broken due to missing jquer...
Comment #9 by b2.temp — 2015-03-29T20:38:52Z
just before closing: Shouldn't win32.mak contain the patch too ? Is it because offline docs are generated with posix.mak ?
Comment #10 by github-bugzilla — 2015-04-25T14:45:00Z
Comment #11 by github-bugzilla — 2015-06-18T16:54:22Z
Commits pushed to stable at https://github.com/D-Programming-Language/dlang.org https://github.com/D-Programming-Language/dlang.org/commit/f074e250f9ac0079801b3e98eeaad2d33d1c0d98 fix Issue 14329 - [2.067] offline doc - menu broken due to missing jquery-1.7.2.min.js https://github.com/D-Programming-Language/dlang.org/commit/0a92173a062697436456bb84a936ce0d0a3097f8 Merge pull request #942 from CyberShadow/pull-20150325-145525