Bug 14375 – static assert leads to __traits(allMembers) retuning an extra empty entry

This confuses MemberFunctionsTuple alot: /usr/include/dlang/dmd/std/traits.d(3647): Error: string expected as second argument of __traits hasMember instead of "" Tested with GDC (2.065), LDC (2.066.1) and 2.067 ```` class IKeysAPI(string greetings) { static assert(greetings == "Hello world", greetings); } void main() { foreach (method; __traits(allMembers, IKeysAPI!("Hello world"))) { static assert (method.length, "Empty string from the compiler ??"); pragma(msg, method); } } ```` Commenting the static assert makes the foreach pass.

The fix for this is very simple. https://github.com/rikkimax/dmd/blob/master/src/traits.c#L875 It is untested but it is there. Ironically this has been as a PR since before 2.066. https://github.com/D-Programming-Language/dmd/pull/3921 I've tested it on a built executable locally with that PR added. Works fine.

i'm using 3921 PR for a long time in my DMD branch, and i can ack that it is working without any noticeable troubles.

Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/2dfede5829685a97e58f7d32f1d3b6448b4969e4 Fix issue 14375 - static assert leads to __traits(allMembers) retuning an extra empty entry https://github.com/D-Programming-Language/dmd/commit/714d1b32cfe721e6266ebbc096355c8ce109f8b8 Merge pull request #4578 from Geod24/fix-14375 Fix issue 14375 - static assert leads to __traits(allMembers) retuning an extra empty entry

Commit pushed to stable at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/bbe9fd2bd561d2b1c72f246d30fd1d9681d8dfe1 Fix issue 14375 - static assert leads to __traits(allMembers) retuning an extra empty entry

Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/bbe9fd2bd561d2b1c72f246d30fd1d9681d8dfe1 Fix issue 14375 - static assert leads to __traits(allMembers) retuning an extra empty entry

Commits pushed to stable at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/2dfede5829685a97e58f7d32f1d3b6448b4969e4 Fix issue 14375 - static assert leads to __traits(allMembers) retuning an extra empty entry https://github.com/D-Programming-Language/dmd/commit/714d1b32cfe721e6266ebbc096355c8ce109f8b8 Merge pull request #4578 from Geod24/fix-14375