← Back to index | Original Bugzilla link

Bug 14464 – coverage merge doesn't work

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P1
Component
druntime
Product
D
Version
D2
Platform
All
OS
All
Creation time
2015-04-19T17:45:00Z
Last change time
2017-07-19T17:41:40Z
Assigned to
nobody
Creator
code

Comments

Comment #0 by code — 2015-04-19T17:45:05Z
Using dmd_coverSetMerge(true) to combine the coverage results of multiple runs produces garbage numbers, because the code in rt.cover that parses the existing .lst files is broken [¹]. Enabling merge only works if .lst files already exist, otherwise coverage generation is silently skipped. Merging coverage reports should be the default, similar to gcov and dmd's -prof, as overwriting existing data is rarely useful. [¹]: https://github.com/D-Programming-Language/druntime/blob/111892fa6ac6bb2005f4f13b4c6bad98399f65b1/src/rt/cover.d#L174
Comment #1 by github-bugzilla — 2015-05-25T23:30:58Z
Commits pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/7a8e9dc85be981710e16c99d528f2e5cbae2883d fix Issue 14464 - coverage merge doesn't work - fix parsing of existing .lst file - use append semantics (create or merge with existing .lst file) - enable merge by default - some code cleanup (reuse buffers, log10, foreach, min/max) https://github.com/D-Programming-Language/druntime/commit/789f02ec42ff9eb8007f282a45126e6252b64453 Merge pull request #1225 from MartinNowak/fix14464 fix Issue 14464 - coverage merge doesn't work
Comment #2 by github-bugzilla — 2015-06-17T21:02:48Z
Commits pushed to stable at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/7a8e9dc85be981710e16c99d528f2e5cbae2883d fix Issue 14464 - coverage merge doesn't work - fix parsing of existing .lst file - use append semantics (create or merge with existing .lst file) - enable merge by default - some code cleanup (reuse buffers, log10, foreach, min/max) https://github.com/D-Programming-Language/druntime/commit/789f02ec42ff9eb8007f282a45126e6252b64453 Merge pull request #1225 from MartinNowak/fix14464
Comment #3 by github-bugzilla — 2017-07-19T17:41:40Z
Commits pushed to dmd-cxx at https://github.com/dlang/druntime https://github.com/dlang/druntime/commit/7a8e9dc85be981710e16c99d528f2e5cbae2883d fix Issue 14464 - coverage merge doesn't work https://github.com/dlang/druntime/commit/789f02ec42ff9eb8007f282a45126e6252b64453 Merge pull request #1225 from MartinNowak/fix14464