Bug 14606 – [REG2.067.0] Bad code with -inline and structs

Crashes on Windows with -m64 -inline: ////////// test.d ///////// struct S { this(long stdTime) { _stdTime = stdTime; } long _stdTime; } S getS() { S sysTime = S(0); return sysTime; } struct T { this(string) { uint[3] arr; s = getS(); } S s; } void main() { T(null); } /////////////////////////// Introduced in https://github.com/D-Programming-Language/dmd/pull/3979

> Introduced in https://github.com/D-Programming-Language/dmd/pull/3979 The broken executable has been generated since 2.065, which and it was introduced in: https://github.com/D-Programming-Language/dmd/pull/2592

Err, confirmed, thanks. I got the original reduction result on Linux but now I can't reproduce it.

Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/10fc5c4227911d4abf4727a283e56afa0aedd783 fix Issue 14606 - Bad code with -inline and structs The wrong-code had caused by the combination of special memset expression `(struct = 0)` and inlining field variable initialization with NRVO. The extended inlining had introduced ConstructExp(ref_var, 0), but it was wrongly handled as reference initialization in AssignExp::toElem(). To fix that, use `BlitExp` for the memset expression always, and avoid confusion with the ref initialization. https://github.com/D-Programming-Language/dmd/commit/58047b08977cc82f09238e8ac6300dd5158a7acb Merge pull request #4683 from 9rnsr/fix14606 [REG2.067.0] Issue 14606 - Bad code with -inline and structs

Commits pushed to stable at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/10fc5c4227911d4abf4727a283e56afa0aedd783 fix Issue 14606 - Bad code with -inline and structs https://github.com/D-Programming-Language/dmd/commit/58047b08977cc82f09238e8ac6300dd5158a7acb Merge pull request #4683 from 9rnsr/fix14606