Bug 14712 – GIT HEAD : std.net.curl regressions

Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2015-06-19T11:37:00Z
Last change time
2017-07-19T17:43:35Z
Keywords
pull
Assigned to
nobody
Creator
temtaime

Comments

Comment #0 by temtaime — 2015-06-19T11:37:18Z
download() no longer works: it seems that it saves ubyte[].to!string now because i see [ 123, 44, 32, ... ] in downloaded file. I've looked in the source and i don't know why now curl uses File.write and opens a file in a binary mode. It should opens the file in wb mode and use rawWrite function instead. Also simple example: import std.net.curl; void main() { download(``, ``); } no longer compiles with following error: src\phobos\std\net\curl.d(292): Error: undefined identifier 'File' src\phobos\std\net\curl.d(299): Error: template instance std.net.curl.download!(FTP) error instantiating main.d(5): instantiated from here: download!(AutoProtocol) src\phobos\std\net\curl.d(299): Error: cannot return non-void from void function Seems that one forgot import std.stdio;
Comment #1 by temtaime — 2015-06-19T11:37:54Z
*and opens a file in the text mode
Comment #2 by ketmar — 2015-06-19T19:52:24Z
Comment #3 by dlang-bugzilla — 2015-06-23T16:59:16Z
Comment #4 by dlang-bugzilla — 2015-06-23T17:04:11Z
Comment #5 by dlang-bugzilla — 2015-06-23T17:05:16Z
*** Issue 14707 has been marked as a duplicate of this issue. ***
Comment #6 by github-bugzilla — 2015-06-23T17:45:34Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/53e4c659682264321e5339615c7a1c6158f8aa6d fix Issue 14712 - GIT HEAD : std.net.curl regressions https://github.com/D-Programming-Language/phobos/commit/04494ce5aea4f338592cc50306dfdc6052d6b91f Merge pull request #3436 from CyberShadow/pull-20150623-170241 fix Issue 14712 - GIT HEAD : std.net.curl regressions
Comment #7 by github-bugzilla — 2015-06-30T16:31:53Z
Commits pushed to stable at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/7a20221c263810f005bedd5e4c05fca656503fa1 fix Issue 14712 - GIT HEAD : std.net.curl regressions https://github.com/D-Programming-Language/phobos/commit/bf66cd106ecad30a5322fbfa740fad87efd4f4b6 Merge pull request #3457 from CyberShadow/pull-20150630-152826-cherrypick-3436 fix Issue 14712 - GIT HEAD : std.net.curl regressions
Comment #8 by brocolis — 2015-07-15T04:26:10Z
*** Issue 14800 has been marked as a duplicate of this issue. ***
Comment #9 by github-bugzilla — 2015-07-25T00:03:26Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/7a20221c263810f005bedd5e4c05fca656503fa1 fix Issue 14712 - GIT HEAD : std.net.curl regressions https://github.com/D-Programming-Language/phobos/commit/bf66cd106ecad30a5322fbfa740fad87efd4f4b6 Merge pull request #3457 from CyberShadow/pull-20150630-152826-cherrypick-3436
Comment #10 by github-bugzilla — 2015-10-04T18:19:43Z
Comment #11 by github-bugzilla — 2017-07-19T17:43:35Z
Commits pushed to dmd-cxx at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/7a20221c263810f005bedd5e4c05fca656503fa1 fix Issue 14712 - GIT HEAD : std.net.curl regressions https://github.com/dlang/phobos/commit/bf66cd106ecad30a5322fbfa740fad87efd4f4b6 Merge pull request #3457 from CyberShadow/pull-20150630-152826-cherrypick-3436