← Back to index | Original Bugzilla link

Bug 14777 – 0 is not the initial value for std.zlib.adler32

Status: RESOLVED
Resolution: FIXED
Severity: enhancement
Priority: P1
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2015-07-06T21:20:00Z
Last change time: 2015-10-04T18:20:35Z
Keywords: pull
Assigned to: nobody
Creator: michalg89

Comments

Comment #0 by michalg89 — 2015-07-06T21:20:23Z

0 is not the initial value for std.zlib.adler32 as stated in the documentation (https://github.com/D-Programming-Language/phobos/blob/master/std/zlib.d#L67). According to zlib docs the initial value should be computed by calling adler32 with null pointer: https://github.com/madler/zlib/blob/master/zlib.h#L1572. Quick look at the source of zlib revelas the true initial value: 1 (https://github.com/madler/zlib/blob/master/adler32.c#L88)

Comment #1 by dlang-bugzilla — 2015-08-31T11:39:57Z

https://github.com/D-Programming-Language/phobos/pull/3610

Comment #2 by github-bugzilla — 2015-08-31T18:33:28Z

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/1156b077b66b8d02f1eb813b676521f60a1ef936 fix Issue 14777 - 0 is not the initial value for std.zlib.adler32 https://github.com/D-Programming-Language/phobos/commit/284bf7606238b52d9c19c9e466129b202858f6db Merge pull request #3610 from CyberShadow/pull-20150831-113910 fix Issue 14777 - 0 is not the initial value for std.zlib.adler32

Comment #3 by github-bugzilla — 2015-10-04T18:20:35Z

Commits pushed to stable at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/1156b077b66b8d02f1eb813b676521f60a1ef936 fix Issue 14777 - 0 is not the initial value for std.zlib.adler32 https://github.com/D-Programming-Language/phobos/commit/284bf7606238b52d9c19c9e466129b202858f6db Merge pull request #3610 from CyberShadow/pull-20150831-113910