Bug 14785 – Some corner cases are not handled properly by core.checkedint.

** Test cases that currently fail ** import core.checkedint; void main(string[] args) { bool overflow = false; assert(subs(-1L, long.min, overflow) == long.max); assert(!overflow); // Assertion failure overflow = false; assert(muls(-1L, long.min, overflow) == long.min); // FPE assert(overflow); } ** Proposed fix ** long subs(long x, long y, ref bool overflow) { long r = cast(ulong)x - cast(ulong)y; if (x < 0 && y >= 0 && r >= 0 || x >= 0 && y < 0 && (r < 0 || y == long.min)) overflow = true; return r; } long muls(long x, long y, ref bool overflow) { long r = cast(ulong)x * cast(ulong)y; enum not0or1 = ~1L; if((x & not0or1) && ((r == y)? r : (r / x) != y)) overflow = true; return r; }

(In reply to thomas.bockman from comment #0) > ** Proposed fix ** Please submit this as a pull request! http://wiki.dlang.org/Pull_Requests

I finally got around to doing so a few days ago: [PR #1365](https://github.com/D-Programming-Language/druntime/pull/1365)

Great, thanks!

Commits pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/799a68968ee5c92452b863851fa32d762cba180f Fix Issue 14785 - Some corner cases are not handled properly by core.checkedint. https://github.com/D-Programming-Language/druntime/commit/acb86115d1d1605f5000dd0c2e8308c451716b44 Merge pull request #1365 from tsbockman/issue_14785 Fix Issue 14785 - Some corner cases are not handled properly by core.checkedint.

Commits pushed to stable at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/799a68968ee5c92452b863851fa32d762cba180f Fix Issue 14785 - Some corner cases are not handled properly by core.checkedint. https://github.com/D-Programming-Language/druntime/commit/acb86115d1d1605f5000dd0c2e8308c451716b44 Merge pull request #1365 from tsbockman/issue_14785