← Back to index | Original Bugzilla link

Bug 14995 – std.mmfile incorrectly handles errors in ctor

Status: RESOLVED
Resolution: FIXED
Severity: normal
Priority: P1
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2015-09-01T11:30:00Z
Last change time: 2015-10-04T18:20:42Z
Keywords: pull
Assigned to: nobody
Creator: dlang-bugzilla

Comments

Comment #0 by dlang-bugzilla — 2015-09-01T11:30:27Z

If the MmFile ctor fails, it will often close the file but leave the fd field set. This will cause its destructor to later attempt to close it again, which will either cause an exception (which in turn will likely result in an InvalidMemoryOperationError), or close an unrelated file with the same coincidental fd.

Comment #1 by dlang-bugzilla — 2015-09-01T11:38:18Z

https://github.com/D-Programming-Language/phobos/pull/3619

Comment #2 by github-bugzilla — 2015-09-18T10:01:42Z

Commit pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/290a94243f80585f6b42d022c2584fba51035c05 fix Issue 14995 - std.mmfile incorrectly handles errors in ctor

Comment #3 by github-bugzilla — 2015-10-04T18:20:42Z

Commit pushed to stable at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/290a94243f80585f6b42d022c2584fba51035c05 fix Issue 14995 - std.mmfile incorrectly handles errors in ctor