Bug 15012 – Druntime Makefile whitelists compilers

Comments

Comment #0 by dlang-bugzilla — 2015-09-04T08:56:18Z

https://github.com/D-Programming-Language/druntime/pull/1317 added a whitelist of compiler binaries for which to add certain CFLAGS. This precludes e.g. using wrapper scripts to work around issue 12572. This issue is blocking some of my work on D (I can't bisect certain bugs or build D on certain machines). Introduced in https://github.com/D-Programming-Language/druntime/pull/1317 I've notified the PR author in a comment on the PR five days ago, but no reply: https://github.com/D-Programming-Language/druntime/pull/1317#discussion_r38268116

Comment #1 by code — 2015-09-06T04:01:24Z

This is the same as in the phobos makefile, so it's kind of surprising that you only have an issue with druntime. https://github.com/D-Programming-Language/phobos/blob/88fc63d8d3d47ded732e801d4ccacec21eccb8f2/posix.mak#L96 We could indeed check against the basename of $(CC) and you can explicitly set $(CFLAGS) for other compilers. https://github.com/D-Programming-Language/druntime/pull/1378 https://github.com/D-Programming-Language/phobos/pull/3633

Comment #2 by github-bugzilla — 2015-09-06T16:13:15Z

Commit pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/7b1a6110f35fbd358235385b9bb0c56d91bcc084 remove CC filter for CFLAGS - allows to use compiler wrappers - fixes make CC=/path/to/cc - fixes Issue 15012 - still can be overriden with make CFLAGS=

Comment #3 by github-bugzilla — 2015-09-06T16:13:18Z

Commit pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/0bfc7ca32f074ff4295f567033da4f72b4d377a7 remove CC filter for CFLAGS - allows to use compiler wrappers - fixes make CC=/path/to/cc - fixes Issue 15012 - still can be overriden with make CFLAGS=

Comment #4 by github-bugzilla — 2015-10-04T18:19:20Z

Comment #5 by github-bugzilla — 2015-10-04T18:20:52Z