Bug 15109 – Always gets install dir wrong when uninstalling previous version

When installing a new version, it first uninstalls the prior version. It always gets the install path wrong. The default install dir is C:\D, but I never install there (who wants to spam the root directory?), I install to C:\dev\D. It first offers to uninstall, but there is a greyed out (not-editable) text box showing C:\D (NOT where DMD is installed on my machine), and I can't do anything but click continue. It them complains that it can't find DMD at that path (no shit!), and fails to uninstall. It then proceeds to install the new version, but having failed to uninstall the prior version, it all gets a little messy. DMD installer should remember where it's installed.

I think we can fix this by saving the path in the registry, by adding: InstallDirRegKey HKCU "Software\D" "InstallPath" at the top and WriteRegStr HKCU "Software\D" "InstallPath" $INSTDIR at the bottom (install Section).

Hm, looking at the code, it already does that! InstallDirRegKey HKCU "Software\${DName}" "InstallationFolder" ... WriteRegStr HKLM "SOFTWARE\${DName}" "InstallationFolder" "$INSTDIR" I guess it's not working for some reason?

I just updated to the latest DMD, and the latest installer seems to be working working. I think it may have been fixed after my last NG rant. ;) I'll confirm this on a second PC.

According to git blame, it's been doing this since Brad's revamp on 2014-07-08.

Maybe old installations had the registry populated with a bad path?