← Back to index | Original Bugzilla link

Bug 15187 – dispose for allocators is broken

Status
RESOLVED
Resolution
FIXED
Severity
major
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2015-10-11T17:03:00Z
Last change time
2016-01-03T14:14:36Z
Assigned to
nobody
Creator
ilyayaroshenko

Comments

Comment #0 by ilyayaroshenko — 2015-10-11T17:03:52Z
Current code: ================ void dispose(A, T)(auto ref A alloc, T* p) { static if (hasElaborateDestructor!T) { destroy(*p); } alloc.deallocate(p[0 .. T.sizeof]); } Should be: ================ void dispose(A, T)(auto ref A alloc, T* p) { static if (hasElaborateDestructor!T) { destroy(*p); } alloc.deallocate((cast(void*)p)[0 .. T.sizeof]); }
Comment #1 by ilyayaroshenko — 2015-10-11T17:35:12Z
https://github.com/D-Programming-Language/phobos/pull/3711
Comment #2 by github-bugzilla — 2015-10-14T23:09:15Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/bf64ff48a1821fbe9313fc930ed70f2d9b1bab8a [DMD 2.069][allocators] Fix issue 15187 https://issues.dlang.org/show_bug.cgi?id=15187 Update package.d https://github.com/D-Programming-Language/phobos/commit/f2be4e5e1961ca259497ba0128ec70139b28d088 Merge pull request #3711 from 9il/patch-3 [DMD 2.069][allocators] Fix issue 15187
Comment #3 by github-bugzilla — 2015-10-14T23:18:22Z
Commit pushed to stable at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/0422e29c7edd6fb807dcf878e78d1d3007a6e34b Merge pull request #3711 from 9il/patch-3 [DMD 2.069][allocators] Fix issue 15187
Comment #4 by github-bugzilla — 2015-10-28T10:30:56Z
Commit pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/0422e29c7edd6fb807dcf878e78d1d3007a6e34b Merge pull request #3711 from 9il/patch-3
Comment #5 by github-bugzilla — 2016-01-03T14:14:36Z
Commits pushed to stable at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/bf64ff48a1821fbe9313fc930ed70f2d9b1bab8a [DMD 2.069][allocators] Fix issue 15187 https://github.com/D-Programming-Language/phobos/commit/f2be4e5e1961ca259497ba0128ec70139b28d088 Merge pull request #3711 from 9il/patch-3