← Back to index | Original Bugzilla link

Bug 15208 – Eradicate all uses of "Enforcement failed" in Phobos

Status: RESOLVED
Resolution: FIXED
Severity: enhancement
Priority: P5
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2015-10-15T23:43:00Z
Last change time: 2016-01-03T14:14:46Z
Keywords: diagnostic, pull
Assigned to: nobody
Creator: dlang-bugzilla

Comments

Comment #0 by dlang-bugzilla — 2015-10-15T23:43:54Z

Using enforce() with no message has clearly shown to be poor practice. This class of diagnostic bugs has appeared in a number of instances: https://issues.dlang.org/show_bug.cgi?id=15133 https://issues.dlang.org/show_bug.cgi?id=14949 https://issues.dlang.org/show_bug.cgi?id=9404 https://issues.dlang.org/show_bug.cgi?id=5462 (and variations of the above - just search Bugzilla for "Enforcement failed") We should eradicate all uses of the message-less enforce() in Phobos, at least.

Comment #1 by dlang-bugzilla — 2015-10-15T23:47:39Z

https://github.com/D-Programming-Language/phobos/pull/3724

Comment #2 by github-bugzilla — 2015-10-16T08:24:57Z

Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/82590904f713df20e7f3d2154fcef851d2609aba fix Issue 15208 - Eradicate all uses of "Enforcement failed" in Phobos https://github.com/D-Programming-Language/phobos/commit/2d67fd111f4fa500e95e6b7aa0730035b3ba2df6 Merge pull request #3724 from CyberShadow/pull-20151015-233512 fix Issue 15208 - Eradicate all uses of "Enforcement failed" in Phobos

Comment #3 by github-bugzilla — 2016-01-03T14:14:46Z

Commits pushed to stable at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/82590904f713df20e7f3d2154fcef851d2609aba fix Issue 15208 - Eradicate all uses of "Enforcement failed" in Phobos https://github.com/D-Programming-Language/phobos/commit/2d67fd111f4fa500e95e6b7aa0730035b3ba2df6 Merge pull request #3724 from CyberShadow/pull-20151015-233512