← Back to index | Original Bugzilla link

Bug 15311 – [dmd-internal] DsymbolExp.resolve and DotIdExp.semanticY (eright.op == TOKimport) need to be merged

Status
RESOLVED
Resolution
WORKSFORME
Severity
normal
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
All
Creation time
2015-11-10T02:56:44Z
Last change time
2022-10-13T08:13:56Z
Assigned to
No Owner
Creator
Kenji Hara
Depends on
14858, 15116, 15117, 15310

Comments

Comment #0 by k.hara.pg — 2015-11-10T02:56:44Z
DsymbolExp.resolve converts a D symbol to corresponding expression object. In DotIdExp.semanticY, if eright.op == TOKimport, the found symbol is converted to corresponding expression object with the 'eleft' context. They're doing similar work, but they are not yet enough consistent. Issue 14858, issue 15116, issue 15117, and issue 15310 (14603 and 14604) have been caused by the inconsistency between them. I think, DsymbolExp.resolve should take one more parameter 'eleft', and if it's not null, it should work like DotIdExp.semanticY.
Comment #1 by razvan.nitu1305 — 2022-10-13T08:13:56Z
DsymbolExp.resolve is named symbolToExp now and its implementation has diverged significantly from semanticY. As such, this bug report is no longer relevant.