Bug 15323 – Module.members and .deferred3 should use data structure with fast lookup

On a moderately sized build (yes, per-package), iterating Module::members and Module::deferred3 over and over again to check whether they already contain a given template instance takes up a noticeable amount of time (about 5% and 3% of the total compilation time). The arrays should probably be replaced by a structure with sub-linear lookup for an easy compile-time win in template-heavy projects.

More information here: http://www.digitalmars.com/d/archives/digitalmars/D/DMD_internal_appendToModuleMember_performance_283463.html

A better solution is have the template instance contain a field which has a pointer to which members[] it is contained in (since it is never contained in more than one).

Commits pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/cef279d5a192ca643593739661f385b1c3851106 fix Issue 15323 - Module.members and .deferred3 should use data structure with fast lookup https://github.com/dlang/dmd/commit/d57ca4c43ffa03628ed414b4a968acd63c4ef17d Merge pull request #5693 from WalterBright/fix15323 fix Issue 15323 - Module.members and .deferred3 should use data struc…

Commits pushed to stable at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/cef279d5a192ca643593739661f385b1c3851106 fix Issue 15323 - Module.members and .deferred3 should use data structure with fast lookup https://github.com/dlang/dmd/commit/d57ca4c43ffa03628ed414b4a968acd63c4ef17d Merge pull request #5693 from WalterBright/fix15323