Bug 15402 – allow private access to package symbols

As indicated by issue# 8716 and issue# 15395, at least occasionally, folks use the package attribute on symbols in modules that aren't actually in a package (since they're at the top level of the hierarchy). Given that it makes no sense to use the package attribute on _anything_ in a top-level module, I'd suggest that it be made into an error to do so. Certainly, it makes more sense than allowing an unusable function to be declared and then make it an error to use it, which is the current behavior.

Package is a superset of private, so it should allow the same access.

Commit pushed to fix15402 at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/c424690156a6f2b4f402415c45e780833f2f2df2 fix Issue 15402 - allow private access to package symbols

I'm reopening because the commit was not actually pushed to master or stable.

Commits pushed to stable at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/c424690156a6f2b4f402415c45e780833f2f2df2 fix Issue 15402 - allow private access to package symbols https://github.com/D-Programming-Language/dmd/commit/e36364035fb1cd689df86f599f8473e1bef10ab5 Merge pull request #5642 from D-Programming-Language/fix15402 fix Issue 15402 - allow private access to package symbols

*** Issue 8716 has been marked as a duplicate of this issue. ***

Commits pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/c424690156a6f2b4f402415c45e780833f2f2df2 fix Issue 15402 - allow private access to package symbols https://github.com/dlang/dmd/commit/e36364035fb1cd689df86f599f8473e1bef10ab5 Merge pull request #5642 from D-Programming-Language/fix15402