← Back to index | Original Bugzilla link

Bug 15403 – [internal] FileExp represents ImportExpression, the AST class naming is not intuitive

Status
RESOLVED
Resolution
FIXED
Severity
trivial
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
All
Creation time
2015-12-04T00:51:00Z
Last change time
2016-01-03T14:02:41Z
Keywords
ice, pull
Assigned to
nobody
Creator
k.hara.pg

Comments

Comment #0 by k.hara.pg — 2015-12-04T00:51:09Z
In expression.d: extern (C++) final class FileExp : UnaExp { public: extern (D) this(Loc loc, Expression e) { super(loc, TOKimport, __traits(classInstanceSize, FileExp), e); } By recent issue 15394 fix (PR #5294), it's changed to use TOKimport. So I think it's a time to rename FileExp to ImportExp.
Comment #1 by k.hara.pg — 2015-12-04T00:57:39Z
https://github.com/D-Programming-Language/dmd/pull/5297
Comment #2 by github-bugzilla — 2015-12-04T02:08:05Z
Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/2da32b038b5de712839a22397273685a44a521c3 fix Issue 15403 - [internal] FileExp represents ImportExpression, the AST class naming is not intuitive Rename `FileExp` to `ImportExp`. https://github.com/D-Programming-Language/dmd/commit/86d7cc4177587cf4d5bdfce052df0a58e1cf7166 Merge pull request #5297 from 9rnsr/fix15403 Issue 15403 - [internal] FileExp represents ImportExpression, the AST class naming is not intuitive
Comment #3 by github-bugzilla — 2016-01-03T14:02:41Z
Commits pushed to stable at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/2da32b038b5de712839a22397273685a44a521c3 fix Issue 15403 - [internal] FileExp represents ImportExpression, the AST class naming is not intuitive https://github.com/D-Programming-Language/dmd/commit/86d7cc4177587cf4d5bdfce052df0a58e1cf7166 Merge pull request #5297 from 9rnsr/fix15403