Bug 15453 – Check for a wrong predefined version identifier CRuntime_Digitalmars

Status
RESOLVED
Resolution
FIXED
Severity
minor
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
Windows
Creation time
2015-12-16T04:45:00Z
Last change time
2016-03-19T20:21:32Z
Keywords
accepts-invalid, pull
Assigned to
nobody
Creator
jiki
Depends on
15452

Comments

Comment #0 by jiki — 2015-12-16T04:45:25Z
This relates to a document issue. https://issues.dlang.org/show_bug.cgi?id=15452 The compiler normally rejects same version identifiers as predefined. Now, 2.069 added some predefined version identifiers in forms of CRuntime_xxx. -------------------------------------- dmd.exe -version=CRuntime_Digitalmars Error: version identifier 'CRuntime_Digitalmars' is reserved and cannot be set dmd.exe -version=CRuntime_DigitalMars (accepts-invalid) -------------------------------------- Checker: CRuntime_Digitalmars ( small 'm' ). Correct: CRuntime_DigitalMars Though the document spec has same mistake as this, many codes in Phobos and Druntime write **Mars actually. (which is working well) So I think this is to be fixed.
Comment #1 by jiki — 2016-01-06T00:44:41Z
Comment #2 by jiki — 2016-01-06T01:07:15Z
(In reply to jiki from comment #0) > -------------------------------------- > dmd.exe -version=CRuntime_Digitalmars > Error: version identifier 'CRuntime_Digitalmars' is reserved and cannot be > set > > dmd.exe -version=CRuntime_DigitalMars > (accepts-invalid) > -------------------------------------- > > Checker: CRuntime_Digitalmars ( small 'm' ). > Correct: CRuntime_DigitalMars > And more: -------------------------------------- dmd -deps hello.d depsVersion core.stdc.stdio (*/druntime/import/core/stdc/stdio.d) : CRuntime_DigitalMars # This line appears multiple times, which should be suppressed. -------------------------------------- I tested in Windows 7.
Comment #3 by github-bugzilla — 2016-01-06T03:25:50Z
Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/f3d5e80026fad96c386efec1888020c4c3905fc3 Issue 15453 - Check for a wrong predefined version identifier CRuntime_Digitalmars This requires a fix in doc ( Issue 15452 ). https://github.com/D-Programming-Language/dlang.org/pull/1168 https://github.com/D-Programming-Language/dmd/commit/86c831a87da76c46261b8a88c5f436470df92ae1 Merge pull request #5332 from qchikara/patch-1 Issue 15453 - Check for a wrong predefined version identifier CRuntim…
Comment #4 by github-bugzilla — 2016-03-19T20:21:32Z
Commits pushed to stable at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/f3d5e80026fad96c386efec1888020c4c3905fc3 Issue 15453 - Check for a wrong predefined version identifier CRuntime_Digitalmars https://github.com/D-Programming-Language/dmd/commit/86c831a87da76c46261b8a88c5f436470df92ae1 Merge pull request #5332 from qchikara/patch-1