Bug 1557 – std.zlib allocates void[]s instead of ubyte[]s, causing leaks.

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P2
Component
phobos
Product
D
Version
D1 (retired)
Platform
x86
OS
All
Creation time
2007-10-08T17:25:00Z
Last change time
2014-02-24T15:59:57Z
Assigned to
bugzilla
Creator
fvbommel

Attachments

IDFilenameSummaryContent-TypeSize
190zlib.diffThe patch mentioned in the initial report.text/plain3088

Comments

Comment #0 by fvbommel — 2007-10-08T17:25:51Z
std.zlib allocates buffers as void[]s instead of ubyte[]s. While in each instance std.gc.hasNoPointers is promptly called on the result, there are concatenations performed with void[] arrays and those don't preserve that attribute. The URL entered is to a discussion of this bug in digitalmars.D, though it manifested in relation to GDC and I haven't verified a memory leak actually exists in the DMD version. However, the module is nearly identical and AFAIK the GC hasn't been upgraded since the version GDC was based on (1.020) either. I'm attaching a patch against DMD 1.022 std.zlib with the following changes: 1) I changed all newly-allocated arrays to ubyte[] instead of void[]. 2) I also took the opportunity to change some cast(ubyte*)s on those void[]s to uses of the .ptr property. 3) std.gc.hasNoPointers() is no longer needed; I removed all calls to it and removed the import. I haven't extensively tested correctness. However this patch is rather trivial, the changed code compiles and the unit test succeeds so I don't think I could've broken anything.
Comment #1 by fvbommel — 2007-10-08T17:26:51Z
Created attachment 190 The patch mentioned in the initial report.
Comment #2 by bugzilla — 2007-11-03T21:48:22Z
Fixed dmd 1.023 and 2.007