← Back to index | Original Bugzilla link

Bug 15677 – std.experimental.allocators.expandArray overload with init should take the array by ref.

Status: RESOLVED
Resolution: FIXED
Severity: minor
Priority: P1
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2016-02-12T21:17:00Z
Last change time: 2016-02-14T17:13:08Z
Assigned to: nobody
Creator: qaston

Comments

Comment #0 by qaston — 2016-02-12T21:17:48Z

All other overloads of std.experimental.allocators.expandArray take an array by reference and modify the given array to allow the caller to use the expanded array. It should be the same for the overload which takes init value, but it looks like that someone forgot to put the ref modifier there.

Comment #1 by qaston — 2016-02-12T21:18:49Z

I've solved the issue in the following PR: https://github.com/D-Programming-Language/phobos/pull/3979#issuecomment-181714618

Comment #2 by github-bugzilla — 2016-02-14T17:13:08Z

Commit pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/84600a2265291df8a8d0c030eea4795e31df21f0 Merge pull request #3979 from QAston/patch-1 Fix Issue 15677. Take array by ref for expandArray with init