Bug 15750 – net/isemail uses lots of redundant helper methods

Status
NEW
Severity
enhancement
Priority
P4
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2016-03-03T17:21:01Z
Last change time
2024-12-01T16:26:09Z
Keywords
bootcamp
Assigned to
No Owner
Creator
Seb
Moved to GitHub: phobos#10163 →

Comments

Comment #0 by greeenify — 2016-03-03T17:21:01Z
In my cleanup task I saw that std.net.isemail seems to do some redundant effort and defines those methods as its own helper: - substr - max - compareFirstN - grep - get There is `backPop`! All of these methods (at least max, substr) feel general purpose enough that they should existent in a general fashion. Btw for max: doesn't work get with ranges, but there is a pending pull request. https://github.com/D-Programming-Language/phobos/pull/4019
Comment #1 by github-bugzilla — 2017-07-09T17:20:22Z
Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/5c31dd26ed289b397a4bad32ac29af6e77247ef7 Issue 15750 - remove substr from std.net.isemail https://github.com/dlang/phobos/commit/e9ff980095462ee88713bcea3cc9852de5081e5b Merge pull request #5585 from wilzbach/remove-substr Issue 15750 - remove substr from std.net.isemail merged-on-behalf-of: Jack Stouffer <[email protected]>
Comment #2 by github-bugzilla — 2017-08-16T13:23:49Z
Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/5c31dd26ed289b397a4bad32ac29af6e77247ef7 Issue 15750 - remove substr from std.net.isemail https://github.com/dlang/phobos/commit/e9ff980095462ee88713bcea3cc9852de5081e5b Merge pull request #5585 from wilzbach/remove-substr
Comment #3 by github-bugzilla — 2018-01-05T13:30:07Z
Commits pushed to dmd-cxx at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/5c31dd26ed289b397a4bad32ac29af6e77247ef7 Issue 15750 - remove substr from std.net.isemail https://github.com/dlang/phobos/commit/e9ff980095462ee88713bcea3cc9852de5081e5b Merge pull request #5585 from wilzbach/remove-substr
Comment #4 by robert.schadek — 2024-12-01T16:26:09Z
THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/phobos/issues/10163 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB