← Back to index | Original Bugzilla link

Bug 15838 – Many Win32 API callback functions miss extern(Windows)

Status
RESOLVED
Resolution
FIXED
Severity
major
Priority
P1
Component
druntime
Product
D
Version
D2
Platform
All
OS
Windows
Creation time
2016-03-27T07:14:59Z
Last change time
2018-01-05T13:27:27Z
Keywords
pull
Assigned to
No Owner
Creator
jiki

Comments

Comment #0 by jiki — 2016-03-27T07:14:59Z
2.070 druntime comes with rich core.sys.windows.* headers for Windows. So, each of their functions should have an exact linkage type. Otherwise the calls to them will cause runtime errors. I found a number of the mismatch for (only) the callback functions, and will send a PR for it.
Comment #1 by jiki — 2016-03-27T17:17:27Z
https://github.com/D-Programming-Language/druntime/pull/1525
Comment #2 by github-bugzilla — 2016-04-10T15:07:09Z
Commits pushed to master at https://github.com/D-Programming-Language/druntime https://github.com/D-Programming-Language/druntime/commit/699dab51b73c37ccf3e397cffb34c2c49198f7e6 Fix issue 15838 Many Win32 API callback functions miss extern(Windows) Add extern (Windows) to aliases and struct fields. https://github.com/D-Programming-Language/druntime/commit/ce29bfc31385a988555a0ba1ab335c81c5173b03 Merge pull request #1525 from qchikara/pr_win32_callbacks_linkeage Fix issue 15838 Many Win32 API callback functions miss extern(Windows)
Comment #3 by jiki — 2016-05-18T03:55:52Z
*** Issue 16032 has been marked as a duplicate of this issue. ***
Comment #4 by github-bugzilla — 2016-10-01T11:44:37Z
Commits pushed to stable at https://github.com/dlang/druntime https://github.com/dlang/druntime/commit/699dab51b73c37ccf3e397cffb34c2c49198f7e6 Fix issue 15838 Many Win32 API callback functions miss extern(Windows) https://github.com/dlang/druntime/commit/ce29bfc31385a988555a0ba1ab335c81c5173b03 Merge pull request #1525 from qchikara/pr_win32_callbacks_linkeage
Comment #5 by github-bugzilla — 2018-01-05T13:27:27Z
Commits pushed to dmd-cxx at https://github.com/dlang/druntime https://github.com/dlang/druntime/commit/699dab51b73c37ccf3e397cffb34c2c49198f7e6 Fix issue 15838 Many Win32 API callback functions miss extern(Windows) https://github.com/dlang/druntime/commit/ce29bfc31385a988555a0ba1ab335c81c5173b03 Merge pull request #1525 from qchikara/pr_win32_callbacks_linkeage