← Back to index | Original Bugzilla link

Bug 15959 – core.sys.windows modules should be modified for x64

Status: RESOLVED
Resolution: FIXED
Severity: major
Priority: P1
Component: druntime
Product: D
Version: D2
Platform: x86_64
OS: Windows
Creation time: 2016-04-27T03:33:00Z
Last change time: 2016-10-01T11:44:51Z
Keywords: pull
Assigned to: nobody
Creator: jiki

Comments

Comment #0 by jiki — 2016-04-27T03:33:58Z

core.sys.windows.* modules came with 2.070. However, their support for x64 are not enough, then some of those API's need modified. The above MSDN link is the list of the APIs affected by x64. (I've been searching for it!) I'll send a PR later.

Comment #1 by jiki — 2016-04-29T00:19:11Z

Fixed, and one more fix missed in list above. https://github.com/dlang/druntime/pull/1552

Comment #2 by jiki — 2016-04-29T00:28:27Z

*** Issue 15955 has been marked as a duplicate of this issue. ***

Comment #3 by github-bugzilla — 2016-05-03T09:39:13Z

Commit pushed to master at https://github.com/dlang/druntime https://github.com/dlang/druntime/commit/e64c3ec15841943d9fa274171f2a7ad11630ba1d Merge pull request #1552 from qchikara/pr-winapi-x64 Fix Issue 15959 - core.sys.windows modules should be modified for x64

Comment #4 by jiki — 2016-05-13T04:37:25Z

Reopend. I have a bad news and a good news. BAD one: The above list sucks absolutely. Hundreds of DWORD_PTR, LONG_PTR, and INT_PTR are sprinkled over Windows SDK. So we have to detect corresponding ones in our druntime and to fix. GOOD one: I've decided to carry out this task. It is close to the end. :|

Comment #5 by jiki — 2016-05-13T10:51:58Z

https://github.com/dlang/druntime/pull/1574

Comment #6 by jiki — 2016-05-18T12:18:07Z

Aaaaaand MORE: https://github.com/dlang/druntime/pull/1575 About SIZE_T's, I did the same routine (detect and replace). They are much less than above.

Comment #7 by github-bugzilla — 2016-05-19T19:08:25Z

Commit pushed to master at https://github.com/dlang/druntime https://github.com/dlang/druntime/commit/fa93b0b2ac3214f020c7f96859c5dcfd61fbff9b Merge pull request #1575 from qchikara/pr-size_t More fix of issue 15959 (size_t)

Comment #8 by jiki — 2016-05-20T04:45:43Z

#1552 #1575 was merged, thanks. But #1574 remains. ( which has the most fixes )

Comment #9 by github-bugzilla — 2016-05-22T14:42:37Z

Commit pushed to master at https://github.com/dlang/druntime https://github.com/dlang/druntime/commit/caf04060ca300ac0ca68e68e9b8de6fecec281cc Merge pull request #1574 from qchikara/additional-15959 Fix issue 15959 additional fixes

Comment #10 by github-bugzilla — 2016-10-01T11:44:51Z

Commits pushed to stable at https://github.com/dlang/druntime https://github.com/dlang/druntime/commit/e64c3ec15841943d9fa274171f2a7ad11630ba1d Merge pull request #1552 from qchikara/pr-winapi-x64 https://github.com/dlang/druntime/commit/fa93b0b2ac3214f020c7f96859c5dcfd61fbff9b Merge pull request #1575 from qchikara/pr-size_t https://github.com/dlang/druntime/commit/caf04060ca300ac0ca68e68e9b8de6fecec281cc Merge pull request #1574 from qchikara/additional-15959