← Back to index | Original Bugzilla link

Bug 16147 – Provide shiny 404 error pages

Status
RESOLVED
Resolution
WORKSFORME
Severity
enhancement
Priority
P1
Component
dlang.org
Product
D
Version
D2
Platform
x86_64
OS
Linux
Creation time
2016-06-09T16:27:00Z
Last change time
2017-06-15T05:32:17Z
Keywords
pull
Assigned to
nobody
Creator
greensunny12

Comments

Comment #0 by greensunny12 — 2016-06-09T16:27:14Z
From the forum: Not only, and this is even more "critical" for new users. If I type "https://dlang.org//asdasd" instead of "https://dlang.org/", the server returns us a "ugly" 404 error page.
Comment #1 by dlang-bugzilla — 2016-11-08T01:25:08Z
https://github.com/dlang/dlang.org/pull/1512
Comment #2 by github-bugzilla — 2016-11-10T10:08:38Z
Commits pushed to master at https://github.com/dlang/dlang.org https://github.com/dlang/dlang.org/commit/dc537e52e541fc69b3e1c6ebc92c67943f4e2ec7 fix Issue 16147 - Provide shiny 404 error pages https://github.com/dlang/dlang.org/commit/6989d12fc4ee006ac7efbb1951363ae0ec40d787 Merge pull request #1512 from CyberShadow/pull-20161108-012203 fix Issue 16147 - Provide shiny 404 error pages
Comment #3 by github-bugzilla — 2016-12-27T13:11:04Z
Commits pushed to scope at https://github.com/dlang/dlang.org https://github.com/dlang/dlang.org/commit/dc537e52e541fc69b3e1c6ebc92c67943f4e2ec7 fix Issue 16147 - Provide shiny 404 error pages https://github.com/dlang/dlang.org/commit/6989d12fc4ee006ac7efbb1951363ae0ec40d787 Merge pull request #1512 from CyberShadow/pull-20161108-012203
Comment #4 by github-bugzilla — 2017-01-07T03:02:16Z
Commits pushed to stable at https://github.com/dlang/dlang.org https://github.com/dlang/dlang.org/commit/dc537e52e541fc69b3e1c6ebc92c67943f4e2ec7 fix Issue 16147 - Provide shiny 404 error pages https://github.com/dlang/dlang.org/commit/6989d12fc4ee006ac7efbb1951363ae0ec40d787 Merge pull request #1512 from CyberShadow/pull-20161108-012203
Comment #5 by github-bugzilla — 2017-01-16T23:24:17Z
Commits pushed to newCTFE at https://github.com/dlang/dlang.org https://github.com/dlang/dlang.org/commit/dc537e52e541fc69b3e1c6ebc92c67943f4e2ec7 fix Issue 16147 - Provide shiny 404 error pages https://github.com/dlang/dlang.org/commit/6989d12fc4ee006ac7efbb1951363ae0ec40d787 Merge pull request #1512 from CyberShadow/pull-20161108-012203
Comment #6 by dfj1esp02 — 2017-01-27T08:57:39Z
Is it supposed to look like this https://abload.de/img/tmp62xp4.png ?
Comment #7 by dlang-bugzilla — 2017-01-27T09:54:04Z
(In reply to anonymous4 from comment #6) > Is it supposed to look like this https://abload.de/img/tmp62xp4.png ? Uh-oh. No. Looks like the 404 pages are only styled correctly on root. We should use root-relative URLs for all resources on the 404 page, I guess.
Comment #8 by greensunny12 — 2017-06-15T05:27:11Z
This works fine for me, e.g. http://dlang.org/foo http://dlang.org/foo/bar/foo And it looks like the resource URLs are set properly in the HTML: <link rel="stylesheet" href="/css/codemirror.css"> <link rel="stylesheet" href="/css/style.css"> <link rel="stylesheet" href="/css/print.css" media="print">
Comment #9 by dlang-bugzilla — 2017-06-15T05:32:17Z
Yes, fixed by https://github.com/dlang/dlang.org/pull/1603