Bug 16170 – std.algorithm.sorting.partition has many issues

Status
NEW
Severity
normal
Priority
P3
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2016-06-14T06:43:09Z
Last change time
2024-12-01T16:27:08Z
Assigned to
No Owner
Creator
Jack Stouffer
Moved to GitHub: phobos#10182 →

Comments

Comment #0 by jack — 2016-06-14T06:43:09Z
* The SwapStrategy.semistable branch does not call save for result, therefore this breaks with forward ranges * The SwapStrategy.unstable !isDynamicArray branch does not call save for result, therefore this breaks with forward ranges * The SwapStrategy.unstable !isDynamicArray branch requires a bidirectional range, only forward range primitives are tested for * is(typeof(swap(result.front, r.front))) is never tested for A lot of this stems from the fact that arrays are the only means of testing for this function
Comment #1 by github-bugzilla — 2016-09-30T15:43:23Z
Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/e21f2729ba3f99605c7db5572c96ad83b1b7ae86 [Issue 16170] Seperate std.algorithm.sorting.partition into various overloads in order to facilitate further improvements https://github.com/dlang/phobos/commit/b2978040ca3c0f061f283e4f433507b635337efb Merge pull request #4429 from JackStouffer/issue16170 [Issue 16170] Partial Fix for Broken std.algorithm.sorting.partition
Comment #2 by github-bugzilla — 2016-10-01T11:47:32Z
Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/e21f2729ba3f99605c7db5572c96ad83b1b7ae86 [Issue 16170] Seperate std.algorithm.sorting.partition into various overloads in order to facilitate further improvements https://github.com/dlang/phobos/commit/b2978040ca3c0f061f283e4f433507b635337efb Merge pull request #4429 from JackStouffer/issue16170
Comment #3 by robert.schadek — 2024-12-01T16:27:08Z
THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/phobos/issues/10182 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB