← Back to index | Original Bugzilla link

Bug 16241 – std.xml mistakenly disallows "==" in comments but allows "--"

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
x86_64
OS
Linux
Creation time
2016-07-06T14:29:00Z
Last change time
2016-10-01T11:46:12Z
Keywords
pull
Assigned to
ag0aep6g
Creator
ag0aep6g

Comments

Comment #0 by ag0aep6g — 2016-07-06T14:29:07Z
---- void main() { import std.xml; auto doc1 = new Document("<r><!-- -- --></r>"); /* accepted */ auto doc2 = new Document("<r><!-- == --></r>"); /* rejected */ } ---- Should be the other way around. Seems like a simple typo in the code. Going to make a PR.
Comment #1 by ag0aep6g — 2016-07-06T14:33:58Z
https://github.com/dlang/phobos/pull/4570
Comment #2 by github-bugzilla — 2016-07-06T23:07:56Z
Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/82afcc0c1933dac726535ec758eacb154b70343a fix issue 16241 - std.xml mistakenly disallows "==" in comments but allows "--" https://github.com/dlang/phobos/commit/5225064a828cab2a2eed049d0006edb546350f22 Merge pull request #4570 from aG0aep6G/16241 fix issue 16241 - std.xml mistakenly disallows "==" in comments but a…
Comment #3 by github-bugzilla — 2016-10-01T11:46:12Z
Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/82afcc0c1933dac726535ec758eacb154b70343a fix issue 16241 - std.xml mistakenly disallows "==" in comments but allows "--" https://github.com/dlang/phobos/commit/5225064a828cab2a2eed049d0006edb546350f22 Merge pull request #4570 from aG0aep6G/16241